Skip to content

chore: fix npm publish#689

Merged
dines-rl merged 1 commit intonextfrom
dines/fix-npm-publish
Jan 22, 2026
Merged

chore: fix npm publish#689
dines-rl merged 1 commit intonextfrom
dines/fix-npm-publish

Conversation

@dines-rl
Copy link
Copy Markdown
Contributor

@dines-rl dines-rl commented Jan 22, 2026

User description

Fix the npm publish to work with OIDC


CodeAnt-AI Description

Publish to npm using OIDC token and Node 24, removing stored NPM token requirement

What Changed

  • The GitHub Actions publish job now requests OIDC id-token write permission so the runner can authenticate to npm without a stored NPM token
  • The job uses Node 24 instead of Node 20 during the publish workflow
  • The publish script no longer requires an injected NPM token and uses npm publish so the OIDC-provided credential is used; stable tagging still runs for non-prerelease versions

Impact

✅ No stored NPM token required for CI publishes
✅ Publishes compatible with Node 24
✅ Fewer publish failures due to missing or rotated tokens

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai
Copy link
Copy Markdown
Contributor

codeant-ai bot commented Jan 22, 2026

CodeAnt AI is reviewing your PR.


Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jan 22, 2026
@codeant-ai
Copy link
Copy Markdown
Contributor

codeant-ai bot commented Jan 22, 2026

Nitpicks 🔍

🔒 No security issues identified
⚡ Recommended areas for review

  • Auth Assumption
    The new code assumes an OIDC-authenticated npm session is already available ("OIDC token is picked up automatically"). If OIDC is not configured or fails, publish will fail. Add an explicit pre-check and clearer failure message so CI diagnostics are actionable.

  • Republish Risk
    The script will call npm publish even if the same VERSION is already published. This can cause CI failures or unintended publish attempts. Consider skipping publish when VERSION equals the registry's latest version or treat it as a no-op.

  • Robustness of npm view parsing
    The script relies on npm view ... --json and uses jq to detect E404 or errors. If npm view returns empty/non-JSON (network issue, rate-limiting, private registry differences), jq checks may behave unexpectedly. Consider stronger validation and clearer error handling for non-JSON responses.

@dines-rl dines-rl merged commit f161f1c into next Jan 22, 2026
7 checks passed
@dines-rl dines-rl deleted the dines/fix-npm-publish branch January 22, 2026 01:30
@stainless-app stainless-app bot mentioned this pull request Jan 22, 2026
@codeant-ai
Copy link
Copy Markdown
Contributor

codeant-ai bot commented Jan 22, 2026

CodeAnt AI finished reviewing your PR.

@stainless-app stainless-app bot mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants