Skip to content

fix: remove spurious warning for optional secrets #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrvb-rl merged 1 commit into from
Mar 6, 2026
Merged

fix: remove spurious warning for optional secrets #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/commands/benchmark-job/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ async function ensureAgentSecrets(
): Promise<Record<string, string>> {
const agentConfig = SUPPORTED_AGENTS[agent];
const secrets: Record<string, string> = {};
const missing: string[] = [];

for (const varName of agentConfig.automaticEnvVars) {
const secretName = `${SECRET_PREFIX}${varName}`;
Expand All @@ -141,7 +142,14 @@ async function ensureAgentSecrets(
await createSecret(secretName, envValue);
secrets[varName] = secretName;
} else {
// No secret and no env var - skip (will be validated later if required)
missing.push(varName);
}
}

// Only warn about missing vars when none were resolved at all
if (missing.length > 0 && Object.keys(secrets).length === 0) {
for (const varName of missing) {
const secretName = `${SECRET_PREFIX}${varName}`;
console.log(
chalk.yellow(
`Secret ${secretName} not found and ${varName} not set in environment`,
Expand Down
Loading