Skip to content

fix(benchmark): set default agent timeout -> 2 hours #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrvb-rl merged 4 commits into from
Mar 9, 2026
Merged

fix(benchmark): set default agent timeout -> 2 hours #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
daede6f
AgentJobConfig.timeout_seconds default -> 2 hours
ross-rl Mar 9, 2026
eef7243
lint
ross-rl Mar 9, 2026
312aff1
cp
ross-rl Mar 9, 2026
ed09259
cp
ross-rl Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/commands/benchmark-job/run.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,9 +326,7 @@ export async function runBenchmarkJob(options: RunOptions) {
const agentConfigs = parsedAgents.map((agent) => ({
name: agent.name,
modelName: agent.model,
timeoutSeconds: options.timeout
? parseInt(options.timeout, 10)
: undefined,
timeoutSeconds: options.timeout ? parseInt(options.timeout, 10) : 7200, // Default to 2 hours
environmentVariables:
Object.keys(providedEnvVars).length > 0 ? providedEnvVars : undefined,
secrets,
Expand All @@ -345,7 +343,9 @@ export async function runBenchmarkJob(options: RunOptions) {

// Output result
if (!options.output || options.output === "text") {
console.log(`Benchmark job created: ${job.id}`);
console.log(
`Benchmark job created: ${job.id} (agent timeout = ${agentConfigs[0].timeoutSeconds}s)`,
);
console.log(`Follow the run with rli benchmark-job watch ${job.id}`);
} else {
output(job, { format: options.output, defaultFormat: "json" });
Expand Down
2 changes: 2 additions & 0 deletions src/screens/BenchmarkJobCreateScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,8 @@ export function BenchmarkJobCreateScreen({
if (!isNaN(timeout) && timeout > 0) {
config.timeoutSeconds = timeout;
}
} else {
config.timeoutSeconds = 7200; // Default to 2 hours
}

return config;
Expand Down
Loading