feat: add 'logs' command to download info from devboxes#164
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jrvb-rl
force-pushed
the
jrvb/add-logs-command
branch
from
0e3033b to
ecb6a11
Compare
Add an rli non-interactive command to fetch, format and print scenario info
james-rl
approved these changes
Mar 10, 2026
Contributor
james-rl
left a comment
james-rl
left a comment
There was a problem hiding this comment.
Looks good. Some questions for you but I don't see any issues
Comment on lines
+115
to
+124
| const outcome = outcomeMap.get(scenarioRunId); | ||
| if (outcome) return outcome.scenario_name; | ||
|
|
||
| try { | ||
| const client = getClient(); | ||
| const scenario = await client.scenarios.retrieve(scenarioId); | ||
| return scenario.name; | ||
| } catch { | ||
| return scenarioId; | ||
| } |
Contributor
There was a problem hiding this comment.
This is more of a nit considering how this function gets used, but the fallback behavior for this test case is quite confusing. I can't see any situation where name would fail to resolve unless the backend was down, in which case eating the error may make troubleshooting harder.
| } | ||
|
|
||
| /** | ||
| * Assign unique destination directories, appending -2, -3, etc. for duplicates. |
Contributor
There was a problem hiding this comment.
Just for knowledge sharing, under what situations would you end up with a duplicate?
It seems like you would need the same scenario name + agent + model name for these to collide. Maybe it would be more intuitive to augment the ScenarioLogTarget with ScenarioId and use that string as a postfix instead of count.
Contributor
Author
There was a problem hiding this comment.
The --n-attempts flag to rli bmj run does N runs of each scenario.
dines-rl
pushed a commit
that referenced
this pull request
Mar 25, 2026
🤖 I have created a release *beep* *boop* --- ## [1.14.0](v1.13.3...v1.14.0) (2026-03-25) ### Features * add 'logs' command to download info from devboxes ([#164](#164)) ([d5354be](d5354be)) * use total_count field from Pagination API response ([#175](#175)) ([4e84f30](4e84f30)) ### Bug Fixes * **benchmark:** fix benchmark id when creating job with benchmark ([#170](#170)) ([2c73cba](2c73cba)) * bmj list now counts finished scenarios from in-progress runs ([#168](#168)) ([123f1d4](123f1d4)) * **cli:** show failure reason when benchmark job fails with no outcomes ([#182](#182)) ([817b5cd](817b5cd)) * **cli:** use allSettled() instead of all() so one bad download doesn't spoil the barrel ([#178](#178)) ([8f4145a](8f4145a)) * don't reset TUI menu cursor on back ([#181](#181)) ([6cc35a7](6cc35a7)) * eliminate flicker in bmj watch and show job elapsed time ([#167](#167)) ([9b1deed](9b1deed)) * prevent double devbox creation when pressing Enter in interactive form ([#173](#173)) ([23f8a28](23f8a28)) * scenarios sometimes listed as in progress after bmj completes ([#174](#174)) ([78f8f55](78f8f55)) * update broken tests ([#169](#169)) ([d8b35a2](d8b35a2)) ### Performance Improvements * **cli:** parallelize scenario log downloads with max concurrency of 50 ([#176](#176)) ([a5828a2](a5828a2)) * **cli:** parallelize scenario run fetching and name resolution in bmj logs ([#179](#179)) ([227d0fd](227d0fd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.