Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
Autofix Details
Bugbot Autofix prepared fixes for both issues found in the latest run.
- ✅ Fixed: VS installer exit code 3010 incorrectly treated as failure
- The Visual Studio installer exit-code check now accepts both 0 and 3010 so reboot-required success no longer aborts bootstrap.
- ✅ Fixed: Native command failures silently ignored in bootstrap script
- Added explicit $LASTEXITCODE checks with throws after rustup component install, git clone, vcpkg bootstrap, and each vcpkg install command.
Or push these changes by commenting:
@cursor push 0729676349
Preview (0729676349)
diff --git a/scripts/bootstrap-windows-runner.ps1 b/scripts/bootstrap-windows-runner.ps1
--- a/scripts/bootstrap-windows-runner.ps1
+++ b/scripts/bootstrap-windows-runner.ps1
@@ -128,7 +128,7 @@
'--includeRecommended'
) -Wait -NoNewWindow -PassThru
-if ($vsProcess.ExitCode -ne 0) {
+if ($vsProcess.ExitCode -ne 0 -and $vsProcess.ExitCode -ne 3010) {
throw "Visual Studio Build Tools installer failed with exit code $($vsProcess.ExitCode). Check the Visual Studio installer logs under $env:TEMP and %ProgramData%\Microsoft\VisualStudio\Packages\_Instances."
}
@@ -171,17 +171,35 @@
throw "rustup.exe was not installed to $(Join-Path $cargoBin 'rustup.exe')."
}
& (Join-Path $cargoBin 'rustup.exe') component add --toolchain $RustToolchain rustfmt clippy
+if ($LASTEXITCODE -ne 0) {
+ throw "rustup component add failed with exit code $LASTEXITCODE"
+}
Write-Host 'Cloning and bootstrapping vcpkg'
if (-not (Test-Path $VcpkgRoot)) {
git clone https://github.com/microsoft/vcpkg.git $VcpkgRoot
+ if ($LASTEXITCODE -ne 0) {
+ throw "git clone for vcpkg failed with exit code $LASTEXITCODE"
+ }
}
& (Join-Path $VcpkgRoot 'bootstrap-vcpkg.bat') -disableMetrics
+if ($LASTEXITCODE -ne 0) {
+ throw "bootstrap-vcpkg.bat failed with exit code $LASTEXITCODE"
+}
Write-Host 'Installing vcpkg packages used by Windows CI'
& (Join-Path $VcpkgRoot 'vcpkg.exe') install "openblas:$Triplet"
+if ($LASTEXITCODE -ne 0) {
+ throw "vcpkg install openblas failed with exit code $LASTEXITCODE"
+}
& (Join-Path $VcpkgRoot 'vcpkg.exe') install "lapack-reference:$Triplet"
+if ($LASTEXITCODE -ne 0) {
+ throw "vcpkg install lapack-reference failed with exit code $LASTEXITCODE"
+}
& (Join-Path $VcpkgRoot 'vcpkg.exe') install "zeromq:$Triplet"
+if ($LASTEXITCODE -ne 0) {
+ throw "vcpkg install zeromq failed with exit code $LASTEXITCODE"
+}
Write-Host 'Writing machine-wide environment variables'
[Environment]::SetEnvironmentVariable('VCPKG_ROOT', $VcpkgRoot, 'Machine')This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
…inux runner; removed wasm from CI
…added more time to the procees
nallana
approved these changes
Apr 3, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Medium Risk
CI/release pipelines are reworked to rely on pre-provisioned self-hosted runners and stricter environment validation, which can break builds/releases if runner setup or PATH/env assumptions are wrong.
Overview
Moves the
CIworkflow’s Linux job to a self-hostedGCPrunner and replaces in-job provisioning with preflight validation of the Rust toolchain and required system libraries; macOS remains usingactions-rs/toolchain/rust-cache.Refactors test execution to generate
test.logconsistently (Linux serializes tests viaRUST_TEST_THREADS=1) and only posts the PR test-summary comment when a log exists.Extends the
Releaseworkflow with a Windows self-hosted build-and-test job (also runnable viaworkflow_dispatchagainst an arbitraryref) and gates release/publish jobs topushevents only. Addsstrawberryperlto Windows dependency setup.Adds infra provisioning scripts:
infra/scripts/bootstrap-linux-runner.sh,infra/scripts/bootstrap-windows-runner.ps1, andinfra/scripts/configure-linux-runner-service-env.shto standardize self-hosted runner setup and deterministicPATH/env configuration.Written by Cursor Bugbot for commit 9f5d3a1. This will update automatically on new commits. Configure here.