Fix renderer-coupled notebook mutations#191
Merged
Merged
Conversation
Collaborator
Author
|
ubuntu-latest failure is an unrelated CI failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
getAllRenderersRefnotebook mutation bug by removing renderer hooks from notebook mutation paths and tightening insert behavior so failed patching does not leave partially inserted cells behind.Changes
getAllRenderersRefbugChatKitPanelActions.updateCellLocal(...)a model-only mutation pathTesting
pnpm -C app exec vitest run src/components/Actions/Actions.test.tsx src/lib/runtime/runmeConsole.test.ts src/lib/runtime/codeModeExecutor.test.tsNotes
tsc -p tsconfig.app.json --noEmitis already failing on unrelated baseline issues in this branch and was not made worse by this change.Actions.tsx/ output-rendering follow-on work remains tracked in Refactor Actions.tsx output rendering and terminal-state handling #190.