Skip to content

Fix renderer-coupled notebook mutations#191

Merged
jlewi merged 4 commits into
mainfrom
dev/jlewi/refbug
Apr 27, 2026
Merged

Fix renderer-coupled notebook mutations#191
jlewi merged 4 commits into
mainfrom
dev/jlewi/refbug

Conversation

@jlewi
Copy link
Copy Markdown
Collaborator

@jlewi jlewi commented Apr 27, 2026

Summary

This PR fixes the getAllRenderersRef notebook mutation bug by removing renderer hooks from notebook mutation paths and tightening insert behavior so failed patching does not leave partially inserted cells behind.

Changes

  • add and refine the design doc for the getAllRenderersRef bug
  • remove renderer callbacks from code-mode notebook mutation in ChatKitPanel
  • make Actions.updateCellLocal(...) a model-only mutation path
  • stop terminal seeding during mutation by making the legacy renderer hook a no-op
  • rollback inserted cells when a later insert patch step fails
  • add focused tests for local mutation behavior and insert rollback

Testing

  • pnpm -C app exec vitest run src/components/Actions/Actions.test.tsx src/lib/runtime/runmeConsole.test.ts src/lib/runtime/codeModeExecutor.test.ts

Notes

@jlewi jlewi requested a review from sourishkrout as a code owner April 27, 2026 18:13
@jlewi
Copy link
Copy Markdown
Collaborator Author

jlewi commented Apr 27, 2026

ubuntu-latest failure is an unrelated CI failure

@jlewi jlewi merged commit 903f9fc into main Apr 27, 2026
2 of 5 checks passed
@jlewi jlewi deleted the dev/jlewi/refbug branch April 27, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant