Add HTML notebook cells#208
Conversation
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
Signed-off-by: Jeremy lewi <jeremy@lewi.us>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f9336a0f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!isRunnableNotebookCodeCell(cell)) { | ||
| throw new Error(`HTML cells are not runnable: ${refId}`); |
There was a problem hiding this comment.
notebooks.execute now throws on any cell that fails isRunnableNotebookCodeCell, but the thrown message and intent are HTML-specific. Because isRunnableNotebookCodeCell also returns false for non-CODE cells, a request that includes a markdown cell ref (e.g., executing a mixed selection) aborts the entire call before runnable code cells start. This is a behavior regression from the previous implementation, which allowed the request to proceed per ref and did not globally fail on markdown refs.
Useful? React with 👍 / 👎.
## Summary - add a dedicated in-place HTML cell mode backed by - render HTML cells through a sandboxed iframe preview, including inline SVG content - add design documentation, serialization coverage, and a browser CUJ that records a walkthrough video ## Testing - runme run build test - pnpm exec vitest run src/components/Actions/Actions.test.tsx src/lib/markdown/serializeNotebookToMarkdown.test.ts - CUJ_UPLOAD=false CUJ_FRONTEND_URL=http://localhost:5174 CUJ_USE_AUTH=false CUJ_DRIVE_FAKE_ENABLED=false CUJ_FAKE_CHATKIT_ENABLED=false CUJ_SCENARIOS=html-cell AGENT_BROWSER_HEADED=true pnpm -C app run cuj:run --------- Signed-off-by: Jeremy lewi <jeremy@lewi.us>
1 participant
Summary
Testing