Open
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sentry Snapshot Testing
|
runningcode
added a commit
to getsentry/sentry
that referenced
this pull request
Apr 14, 2026
Add Celery task that posts/updates GitHub PR comments for snapshot comparisons, and wire it into all existing trigger points. **Task** (`snapshot_tasks.py`): Follows the build distribution PR comment pattern — locks CommitComparison rows to prevent duplicates, finds existing comments across PR commits, creates or updates via GitHub API, stores comment_id in `extras["pr_comments"]["snapshots"]`. Gated by feature flag `organizations:preprod-snapshot-pr-comments` and project option `sentry:preprod_snapshot_pr_comments_enabled` (both already registered). **Wiring**: Triggered alongside the snapshot status check task at five entry points: - Comparison completion and failure (`snapshots/tasks.py`) - Upload completion (`preprod_artifact_snapshot.py`) - Approval via API (`preprod_artifact_approve.py`) - Approval via GitHub check run button (`github_check_run.py`) - Rerun status checks (`preprod_artifact_rerun_status_checks.py`) I might have missed something so let me know if this should be added somewhere else! Here's what this looks like using the test script: [link](runningcode/hackernews#1) <img width="910" height="373" alt="image" src="https://github.com/user-attachments/assets/04569cbf-268d-437b-b0c4-4f2b86541226" /> Depends on #112353. Refs EME-999
Sentry Snapshot Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code