This repository was archived by the owner on Jul 3, 2020. It is now read-only.
Conversation
added 8 commits
July 30, 2016 11:31
git-subtree-dir: deps/json11 git-subtree-split: fb6cc808e0a3532d27ee336cd8f2e1ff06093f3b
Also needed to include it in V8's includes
Somehow it was missed in the code style PR
Member
|
This is amazing, looks great! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows flags for V8 to be configured at runtime by the root project (where the initrd was packed) in
/runtime.json, like:{ "v8": { "flags": "--my-v8-flags --expose-wasm --harmony --more" } }Hopefully,
runtime.jsonwill also contain flags for runtime.js in the future (e.g. enabling SMP).On a minor note, the
performanceglobal has been added to the.eslintrc. Somehow it was overlooked in the code style pull request.