Skip to content

Conversation

@goodlyrottenapple
Copy link
Contributor

@goodlyrottenapple goodlyrottenapple commented Jul 19, 2022

This PR adds a nix expression to build kevm and the associated kevm python library.

Closes #1248

@ehildenb
Copy link
Member

Are we able to put the Nix stuff in a subdirectory like package/nix/...

Currently we put all our other packaging stuff in appropriate subdirectories under package/, not just in the repo root, for everything but the Nix files (in the K repo too). Woudl like to avoid clutter.

@ehildenb
Copy link
Member

@goodlyrottenapple can you set up a GitHub workflow to actually build/run this Nix target on CI? Should be pretty similar to the K repo one, or Haskell backend repo one.

@goodlyrottenapple
Copy link
Contributor Author

Are we able to put the Nix stuff in a subdirectory like package/nix/...

No, flake.nix and flake.lock must live in the root directory

@goodlyrottenapple can you set up a GitHub workflow to actually build/run this Nix target on CI? Should be pretty similar to the K repo one, or Haskell backend repo one.

Sure.

@goodlyrottenapple
Copy link
Contributor Author

i can move the nix/ folder to package/nix/

@ehildenb
Copy link
Member

What about flake.lock and flake.nix? Can we move those to subdirectory too? If not no worries, but if it's possibel I would prefer it.

@goodlyrottenapple
Copy link
Contributor Author

no, those have to be in the root folder, otherwise nix wont find them

Co-authored-by: Everett Hildenbrandt <everett.hildenbrandt@gmail.com>
@rv-jenkins rv-jenkins merged commit c29c112 into master Aug 2, 2022
@rv-jenkins rv-jenkins deleted the nix-flake branch August 2, 2022 19:43
@goodlyrottenapple goodlyrottenapple mentioned this pull request Aug 31, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Nix derivation for KEVM

4 participants