Typed exceptions #187
Merged
Typed exceptions #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
VMTests disabled because: ethereum/tests#444 |
ehildenb
force-pushed
the
typed-exceptions
branch
from
7ce0f31 to
acdfbb9
Compare
Member
Author
|
@dwightguth should be ready for review. The failing proofs are because the proof submodule has not been updated, doing that now but they should go through fine once that's done. |
ehildenb
force-pushed
the
typed-exceptions
branch
7 times, most recently
from
cd8f97d to
f74bad3
Compare
Merged
ehildenb
force-pushed
the
typed-exceptions
branch
3 times, most recently
from
a9f4747 to
2753176
Compare
Contributor
|
Jenkins: test mantis |
ehildenb
force-pushed
the
typed-exceptions
branch
4 times, most recently
from
c47f1a8 to
5af1a7c
Compare
Member
Author
|
Jenkins: test this please |
Member
Author
|
Jenkins: test mantis |
Member
Author
|
Jenkins: test this please |
ehildenb
force-pushed
the
typed-exceptions
branch
from
5af1a7c to
80e73f5
Compare
Member
Author
|
@dwightguth ready for review. @pirapira you may also be interested, this PR adds typed exceptions to KEVM, see file |
ehildenb
force-pushed
the
typed-exceptions
branch
from
80e73f5 to
4871723
Compare
dwightguth
approved these changes
Apr 19, 2018
Contributor
dwightguth
left a comment
dwightguth
left a comment
There was a problem hiding this comment.
looks good but there's one minor thing you should fix before you merge.
network.md
Outdated
| - `EVMC_BAD_JUMP_DESTINATION` indicates a `JUMP*` to a non-`JUMPDEST` location. | ||
| - `EVMC_STACK_OVERFLOW` indicates pushing more than 1024 elements onto the wordstack. | ||
| - `EVMC_STACK_UNDERFLOW` indicates popping elements off an empty wordstack. | ||
| - `EVMC_CALL_DEPTH_EXCEDED` indicates that we have executed too deeply a nested sequence of `CALL*` or `CREATE` opcodes. |
Contributor
There was a problem hiding this comment.
pretty sure exceeded has two es.
added 3 commits
April 19, 2018 12:01
ehildenb
force-pushed
the
typed-exceptions
branch
from
4871723 to
abc14fa
Compare
added 5 commits
April 19, 2018 12:01
…eption, sets `statusCode`
…end => #halt, remove Exception Now instead of using #revert, #end, or #exception, using #end_ to set the status code as well. Code `#halt` is named different than `#end` so that people must explicitely decide not to set the status code if they want to #end.
Member
Author
|
Jenkins: test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplest steps towards typed exceptions, makes refactoring the control flow simpler.