Skip to content

Testing cleanups #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 17, 2018
Merged

Testing cleanups #191

merged 12 commits into from
Apr 17, 2018

Conversation

@ehildenb
Copy link
Member

@ehildenb ehildenb commented Apr 15, 2018

cleanups to testing harness extracted from #187 PR.

@ehildenb ehildenb requested a review from dwightguth April 15, 2018 00:02
@ehildenb
Copy link
Member Author

ehildenb commented Apr 15, 2018

Jenkins: test this please

1 similar comment
@ehildenb
Copy link
Member Author

ehildenb commented Apr 15, 2018

Jenkins: test this please

@ehildenb
Copy link
Member Author

ehildenb commented Apr 15, 2018

@dwightguth ready for review

@ehildenb ehildenb force-pushed the testing-cleanups branch 2 times, most recently from 0c5aeb0 to f78f5df Compare April 16, 2018 01:08
@dwightguth
Copy link
Contributor

dwightguth commented Apr 16, 2018

Jenkins: test mantis

dwightguth
dwightguth suggested changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@dwightguth dwightguth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing that needs changing.

I also had one other question: are you intending to remove the VMTESTS mode in a future PR, or does that need to be done now?

Makefile
tests/ethereum-tests/VMTests/vmRandomTest/201503102037PYTHON.json \
tests/ethereum-tests/VMTests/vmRandomTest/201503102148PYTHON.json \
tests/ethereum-tests/VMTests/vmRandomTest/201503102300PYTHON.json \
tests/ethereum-tests/VMTests/vmRandomTest/201503110050PYTHON.json \
Copy link
Contributor

@dwightguth dwightguth Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-all-vm needs to not test the bad_vm_tests.

Everett Hildenbrandt added 10 commits April 16, 2018 14:49
@ehildenb
Copy link
Member Author

ehildenb commented Apr 16, 2018

@dwightguth I've excluded bad_vm_tests from target test-all-vm. I do intend to eventually completely remove the VMTESTS mode from the semantics, but I think it will have to wait for ethereum/tests#444 (and I assume others which follow) to finish because currently we still need special behaviour for VMTests mode in driver.md.

Once all the "bad" VMTests are removed (that is, all the VMTests which interact with network state at all), we should be able to completely remove VMTests mode.

@ehildenb ehildenb merged commit bba1cbb into master Apr 17, 2018
@ehildenb ehildenb deleted the testing-cleanups branch April 17, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dwightguth dwightguth dwightguth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ehildenb @dwightguth