-
Notifications
You must be signed in to change notification settings - Fork 152
Remove GST test chaining from driver.md #2822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvacaru
commented
Dec 11, 2025
ehildenb
reviewed
Dec 11, 2025
ehildenb
reviewed
Dec 11, 2025
ehildenb
reviewed
Dec 11, 2025
Member
|
Did you confirm that breaking a vmtest and a bchaintest manually and the test-harness correctly finds the breakage? |
Co-authored-by: Everett Hildenbrandt <everett.hildenbrandt@gmail.com>
Contributor
Author
Yes, I modified the [1] anvacaru@desktop kevm-pyk$ uv run -- pytest src/tests/integration --verbose --durations=0 --dist=worksteal --maxfail=3 --numprocesses=2 -k 'test_conformance.py and (15_tstoreCannotBeDosd.json or add.json)
=================================================================================== test session starts ===================================================================================
src/tests/integration/test_conformance.py::test_bchain[stZeroKnowledge/pointAdd.json]
src/tests/integration/test_conformance.py::test_vm[vmArithmeticTest/add.json]
[gw0] [ 25%] FAILED src/tests/integration/test_conformance.py::test_vm[vmArithmeticTest/add.json]
src/tests/integration/test_conformance.py::test_bchain[stZeroKnowledge/pointMulAdd.json]
[gw1] [ 50%] PASSED src/tests/integration/test_conformance.py::test_bchain[stZeroKnowledge/pointAdd.json]
src/tests/integration/test_conformance.py::test_bchain[Cancun/stEIP1153-transientStorage/15_tstoreCannotBeDosd.json]
[gw0] [ 75%] PASSED src/tests/integration/test_conformance.py::test_bchain[stZeroKnowledge/pointMulAdd.json]
[gw1] [100%] FAILED src/tests/integration/test_conformance.py::test_bchain[Cancun/stEIP1153-transientStorage/15_tstoreCannotBeDosd.json]
|
ehildenb
approved these changes
Dec 12, 2025
1e4dda8
into
master
23 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the semantics of
driver.mdand remove the rules associated with chaining multiple tests.runrules to process a single test entry instead of chaining multiple entriesfailure Stringsyntax and associated rules; since only one test is executed at a time and the test harness manages test names externally, this is no longer neededrun,process, andcheckcommandsoutput-success-java.jsonfileoutput-success-{haskell,llvm}.jsonfiles.