Remove node build from semantics #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwightguth
reviewed
May 4, 2020
Member
Author
|
Should be ready for re-review, I've tested locally, and the only thing I'm not convinced of is that the proofs will all pass. |
dwightguth
reviewed
May 4, 2020
evm.md
Outdated
| rule #code?(EXTCODESIZE) => true | ||
| rule #code?(EXTCODECOPY) => true | ||
| rule #code?(OP) => false requires (OP =/=K EXTCODESIZE) andBool (OP =/=K EXTCODECOPY) | ||
| rule <k> #addr [ OP:OpCode ] => . ... </k> [owise] |
Contributor
There was a problem hiding this comment.
pretty sure the java backend doesn't understand owise on non-function rules.
Member
Author
There was a problem hiding this comment.
@dwightguth I converted to an explicit side condition.
Contributor
|
Looks fine. I wonder if we can make that side condition faster by converting it to structural matching, but we can worry about that later. |
dwightguth
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node build is fully subsumed by the Web3 build now, so no need to keep it around, which should allow for some simplifications in the blockchain-k-plugin as well.