Questionable use of concatMap in unit tests

[ttuegel]

Some (not all) unit tests declare concatMap as a functional symbol, which is questionable.

[andreiburdusa]

On some unit test, makeEvaluateTermsToPredicate returns a different OrCondition if we set concatMapSymbol to be function. The difference is this extra condition:

\and{_PREDICATE{}}(
    /* term: */
    /* D Sfa */ \top{_PREDICATE{}}(),
\and{_PREDICATE{}}(
    /* predicate: */
    \and{_PREDICATE{}}(
        /* Sfa */
        \not{_PREDICATE{}}(
            /* Created: Kore.Internal.Conditional.makeAndPredicate */
            /* Sfa */
            \and{_PREDICATE{}}(
                /* Sfa */
                \ceil{testSort{}, _PREDICATE{}}(
                    /* Created: Test.Kore.Step.Simplification.Equals.f */
                    /* Fn Sfa */
                    f{}(/* Fl Fn D Sfa Cl */ a{}())
                ),
                /* Sfa */
                \ceil{testSort{}, _PREDICATE{}}(
                    /* Created: Test.Kore.Step.Simplification.Equals.f */
                    /* Fn Sfa */
                    f{}(/* Fl Fn D Sfa Cl */ b{}())
                )
            )
        ),
        /* Sfa */
        \not{_PREDICATE{}}(
            /* Sfa */
            \ceil{mapSort{}, _PREDICATE{}}(
                /* Created: Test.Kore.Step.Simplification.Equals.concatMap */
                /* Fn Sfa */
                concatMap{}(
                    /* Fl Fn D Sfa */
                    /* builtin: */
                    /* concrete element: */ elementMap{}(
                        /* Fl Fn D Sfa Cl */ a{}(),
                        /* Fl Fn D Sfa */ x:testSort{}
                    ),
                    /* Fl Fn D Sfa */ m:mapSort{}
                )
            )
        )
    ),
    /* substitution: */
    \top{_PREDICATE{}}()
))

I think its description might be relevant:

It does not attempt to fully simplify the terms (the not-ceil parts used to
catch the bottom=bottom case and everything above it), but, if the patterns are
total, this should not be needed anyway.