Add SideCondition argument to simplifyAnds #1846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttuegel
approved these changes
May 22, 2020
Contributor
ttuegel
left a comment
ttuegel
left a comment
There was a problem hiding this comment.
I'd like to reverse the order of the arguments to simplifyAnds so that the MakeAnd is first, but otherwise this looks great!
Comment on lines
181
to
182
| => SideCondition variable | ||
| -> MakeAnd monad |
Contributor
There was a problem hiding this comment.
Let's reverse the order of these arguments.
Comment on lines
212
to
213
| => SideCondition variable | ||
| -> MakeAnd monad |
Contributor
There was a problem hiding this comment.
Let's also reverse the order of these arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See here
Reviewer checklist
stack test --coveragestack haddock