mkDefined: Descend into elements of collections #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ana-pantilie
approved these changes
Jul 28, 2020
Contributor
ana-pantilie
left a comment
ana-pantilie
left a comment
There was a problem hiding this comment.
I pushed a very small refactoring and I changed the test descriptions for the Set tests, because they didn't seem very clear to me at first glance. Feel free to revert the commit if you think it's unnecessary. I also have a question surrounding the constructor-like tests.
| , testCase "Simplifiable non-constructor-like key BuiltinMap" $ | ||
| assertErrorIO (assertSubstring "" "Expecting constructor-like object") $ | ||
| Mock.builtinMap [(Mock.a, Mock.c), (Mock.f Mock.b, Mock.c)] | ||
| `shouldBeConstructorLike` False |
Contributor
There was a problem hiding this comment.
Why were these two tests removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer checklist
stack test --coveragestack haddock