checkSubstitutionCoverage: check for constructor-like configuration #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I used a small |
ttuegel
suggested changes
Jul 29, 2020
Comment on lines
173
to
180
| isSymbolic = | ||
| Foldable.any isSomeConfigVariableName substitutionVariables | ||
| || isNothing | ||
| ( getConstructorLike | ||
| . Attribute.constructorLikeAttribute | ||
| . extractAttributes | ||
| $ term configuration | ||
| ) |
Contributor
There was a problem hiding this comment.
I think we only need to check that the configuration is not constructor-like:
Suggested change
| isSymbolic = | |
| Foldable.any isSomeConfigVariableName substitutionVariables | |
| || isNothing | |
| ( getConstructorLike | |
| . Attribute.constructorLikeAttribute | |
| . extractAttributes | |
| $ term configuration | |
| ) | |
| isSymbolic = (not . isConstructorLike) (term configuration) |
| x |-> _0 | ||
| </state> | ||
| </T> | ||
| #Not ( #Exists I . { |
Contributor
There was a problem hiding this comment.
This test is not right. I think we should remove it.
ttuegel
approved these changes
Jul 30, 2020
Contributor
|
One more thing: can you please add the example from the issue as an integration test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2010
Reviewer checklist
stack test --coveragestack haddock