Add context to some error messages #2017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiburdusa
approved these changes
Jul 28, 2020
| :: HasCallStack | ||
| => Ord variable | ||
| => InternalVariable variable | ||
| => [(SomeVariable variable, TermLike variable)] |
Contributor
There was a problem hiding this comment.
I see Ana left a "TODO" comment on line 431 about a posible refactoring. I could take care of it. What do you think @ana-pantilie @ttuegel ?
(I'm not able to comment on that line)
Contributor
There was a problem hiding this comment.
We already have unsafeWrapFromAssignments, and it looks like the major difference between these two is that unsafeWrap doesn't enforce the variable renaming invariant. I believe the question here is if we want to be able to create a Substitution like this, even for testing (where unsafeWrap is most widely used). @ttuegel what do you think? Is there any reason to keep unsafeWrap the way it is?
ttuegel
commented
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer checklist
stack test --coveragestack haddock