Symbolic rules for SET.in #2073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usa/kore into symbolic-rules-SET.in
…usa/kore into symbolic-rules-SET.in
ttuegel
suggested changes
Aug 21, 2020
kore/src/Kore/Builtin/Set.hs
Outdated
| , keyTerm, mapTerm :: !term | ||
| } | ||
|
|
||
| newtype In term = In { getIn :: InKeys term} |
There was a problem hiding this comment.
Let's call this InSet, just so it doesn't get confused with the other In type.
ttuegel
approved these changes
Aug 25, 2020
This reverts commit d7f74af.
ttuegel
added a commit
to ttuegel/kore
that referenced
this pull request
Sep 3, 2020
This reverts commit 1ced2ee. The symbolic rules applied to the negative case of SET.in, but we need to keep the duality between the negative and positive cases so that the SMT solver can reason about them. (The SMT solver does not have any knowledge of SET.)
ttuegel
added a commit
to ttuegel/kore
that referenced
this pull request
Sep 3, 2020
This reverts commit 1ced2ee. The symbolic rules applied to the negative case, but not the positive case. We need to keep the duality between negative and positive cases so that the SMT solver can reason about them. (The SMT solver has no knowledge of SET.)
ttuegel
added a commit
that referenced
this pull request
Sep 3, 2020
This reverts commit 1ced2ee. The symbolic rules applied to the negative case, but not the positive case. We need to keep the duality between negative and positive cases so that the SMT solver can reason about them. (The SMT solver has no knowledge of SET.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2020
Reviewer checklist
stack test --coveragestack haddock