kore-parser: Make --no-print-definition and --no-print-pattern default and make --module and --pattern mandatory to go together #2273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e parser to False
ttuegel
suggested changes
Nov 17, 2020
Contributor
ttuegel
left a comment
ttuegel
left a comment
There was a problem hiding this comment.
Please add unit tests, particularly to check that the combination --no-print-definition --print-definition works. You will probably have to move enableDisableFlag into the library.
I know that command-line parsing is my favorite example of low-value tests, but I'm starting to change my mind; it's obviously not simple to get command-line parsing right and the tests are easy to write.
ttuegel
changed the title
MirceaS
commented
Nov 24, 2020
ttuegel
suggested changes
Nov 25, 2020
MirceaS
changed the title
ttuegel
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2264
Fixes #2254
Reviewer checklist
stack test --coveragestack haddock