Skip to content

Conversation

@ttuegel
Copy link
Contributor

@ttuegel ttuegel commented Dec 10, 2020

Continuation of #2209.

  • Pull the built-in primitive types out of Builtin:
    • Kore.Internal.InternalInt
    • Kore.Internal.InternalBool
    • Kore.Internal.InternalString
  • Split up the simplification routines for each type.
  • Reduce some duplication in the unification code.
  • Add missing test cases for unification.
  • Update test output. The changes should only be to comments.

Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel marked this pull request as ready for review December 11, 2020 20:52
@ttuegel ttuegel requested a review from ana-pantilie December 15, 2020 15:23
@ttuegel
Copy link
Contributor Author

ttuegel commented Dec 16, 2020

@ana-pantilie I addressed you comments, could you please take another look?

Copy link
Contributor

@ana-pantilie ana-pantilie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I added a commit with some test cases (it used to be a TODO).

@ttuegel
Copy link
Contributor Author

ttuegel commented Dec 17, 2020

@ana-pantilie Oh, I added the same sort of tests at Test.Kore.Builtin.{Bool,String}.test_contradiction. I will consolidate them.

@ana-pantilie
Copy link
Contributor

@ttuegel Sorry, I saw the TODO and thought I could add them quickly, it probably just means the TODO was out of date. You can just revert the commit if you think they're redundant and it's easier that way.

@ttuegel ttuegel merged commit 770f15d into master Dec 18, 2020
@ttuegel ttuegel deleted the cleanup--builtin branch December 18, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants