-
Notifications
You must be signed in to change notification settings - Fork 42
Clean up built-in types #2310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up built-in types #2310
Conversation
The local function simplifier moved from Pattern to Condition simplification, so the tests are moved accordingly.
949ade1 to
efe4dc1
Compare
efe4dc1 to
15b324f
Compare
|
@ana-pantilie I addressed you comments, could you please take another look? |
ana-pantilie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I added a commit with some test cases (it used to be a TODO).
|
@ana-pantilie Oh, I added the same sort of tests at |
|
@ttuegel Sorry, I saw the TODO and thought I could add them quickly, it probably just means the TODO was out of date. You can just revert the commit if you think they're redundant and it's easier that way. |
Continuation of #2209.
Builtin:Kore.Internal.InternalIntKore.Internal.InternalBoolKore.Internal.InternalStringReview checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.