Skip to content

Conversation

@andreiburdusa
Copy link
Contributor

@andreiburdusa andreiburdusa commented Mar 11, 2021

Some error messages were being printed to standard output. This could have caused them to be printed in the output file if the user used the flag --output, thus being mixed with the kore pattern.

The present pull request replaces putStrLn with hPutStrLn stderr in those places.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel self-requested a review March 11, 2021 15:33
Copy link
Contributor

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Could you please add to the pull request summary why it is important to use stderr instead of stdout?

@andreiburdusa andreiburdusa requested a review from ttuegel March 15, 2021 09:48
@rv-jenkins rv-jenkins merged commit f0d93ac into master Mar 16, 2021
@rv-jenkins rv-jenkins deleted the errors-to-stderr branch March 16, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants