Skip to content

Conversation

@MirceaS
Copy link
Contributor

@MirceaS MirceaS commented Mar 16, 2021

Fixes #2468


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@rv-jenkins rv-jenkins merged commit fcfc2d5 into master Mar 16, 2021
@rv-jenkins rv-jenkins deleted the 2468 branch March 16, 2021 19:49
@MirceaS MirceaS mentioned this pull request Mar 16, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Evaluated

4 participants