Refactor Unification Loop #2602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
ttuegel
suggested changes
May 14, 2021
Contributor
ttuegel
left a comment
ttuegel
left a comment
There was a problem hiding this comment.
In addition, all of the new top-level definitions need documentation. For the unification cases (which is most of it) this could be as simple as showing the Kore terms that are being unified.
|
|
|
|
|
|
ttuegel
suggested changes
May 18, 2021
|
ttuegel
reviewed
May 20, 2021
emarzion
commented
May 20, 2021
|
|
4 tasks
|
|
|
Apply a worker-wrapper transformation to functions maybeTermAnd and maybeTermEquals to preserve their encapsulation and avoid passing redundant arguments.
ttuegel
force-pushed
the
unification-refactor2
branch
from
d1f740f to
6cbce09
Compare
|
|
ttuegel
approved these changes
Jun 5, 2021
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2396
Replacing branch #2535
The code for maybeTermEquals and maybeTermAnd are being modified as follows: Each
asumis replaced by a list of patterns + function calls, with each invoked function being replaced by two functions, the first corresponding to the pattern match, which returns the necessary data for the second function which performs the unification, now accepting the data from the match as a single argument. The current conventions for returning the data in this PR are:()is returned (since we are returningMaybe ()it may be better to just return aBool, but in the interest of regularity I've chosen the former option).Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.