Skip to content

Conversation

@emarzion
Copy link
Contributor

@emarzion emarzion commented May 21, 2021

Fixes #2396

Continuation of the work done in #2602


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.134098 -0.000054
test/regression-evm/test-sumTo10.sh -0.362090 0.006252
test/regression-evm/test-pop1.sh -0.086308 0.000054
test/regression-evm/test-add0.sh -0.153573 0.000054
test/regression-evm/test-straight-line-no-invalid.sh -0.085201 0.000017
test/regression-evm/test-sum-to-n.sh -0.012837 -0.000754
test/regression-evm/test-straight-line.sh -0.092904 -0.005644
test/regression-evm/test-branching-invalid.sh -0.139081 0.000010
test/regression-wasm/test-memory.sh -0.007135 0.000473
test/regression-wasm/test-simple-arithmetic.sh -0.003889 0.000154
test/regression-wasm/test-locals.sh -0.000248 0.000396
test/regression-wasm/test-wrc20.sh -0.007768 0.016248
test/regression-wasm/test-loops.sh -0.009763 -0.000005

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.115597 -0.000053
test/regression-evm/test-sumTo10.sh -0.317004 0.002258
test/regression-evm/test-pop1.sh -0.074639 0.000054
test/regression-evm/test-add0.sh -0.133582 0.000054
test/regression-evm/test-straight-line-no-invalid.sh -0.073119 0.000018
test/regression-evm/test-sum-to-n.sh -0.007114 0.003882
test/regression-evm/test-straight-line.sh -0.079868 0.000023
test/regression-evm/test-branching-invalid.sh -0.119992 0.000011
test/regression-wasm/test-memory.sh -0.488653 0.000622
test/regression-wasm/test-simple-arithmetic.sh -0.001963 0.000398
test/regression-wasm/test-locals.sh 0.000821 0.000279
test/regression-wasm/test-wrc20.sh -0.953026 -0.087918
test/regression-wasm/test-loops.sh -0.007282 0.000171

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.132777 -0.000054
test/regression-evm/test-sumTo10.sh -0.358631 0.004527
test/regression-evm/test-pop1.sh -0.085513 0.000054
test/regression-evm/test-add0.sh -0.152064 0.000054
test/regression-evm/test-straight-line-no-invalid.sh -0.084421 0.000017
test/regression-evm/test-sum-to-n.sh -0.012899 0.001778
test/regression-evm/test-straight-line.sh -0.092013 0.000025
test/regression-evm/test-branching-invalid.sh -0.137721 0.000011
test/regression-wasm/test-memory.sh -0.007327 0.000508
test/regression-wasm/test-simple-arithmetic.sh -0.004091 0.000283
test/regression-wasm/test-locals.sh -0.000407 0.000205
test/regression-wasm/test-wrc20.sh -0.007783 0.024583
test/regression-wasm/test-loops.sh -0.010197 0.000181

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.134442 -0.000054
test/regression-evm/test-sumTo10.sh -0.362579 0.004255
test/regression-evm/test-pop1.sh -0.086499 0.000054
test/regression-evm/test-add0.sh -0.153874 0.000054
test/regression-evm/test-straight-line-no-invalid.sh -0.085471 0.000017
test/regression-evm/test-sum-to-n.sh -0.013077 0.002696
test/regression-evm/test-straight-line.sh -0.093152 0.000023
test/regression-evm/test-branching-invalid.sh -0.139449 0.000010
test/regression-wasm/test-memory.sh -0.007245 0.000505
test/regression-wasm/test-simple-arithmetic.sh -0.003992 0.000235
test/regression-wasm/test-locals.sh -0.000315 0.000205
test/regression-wasm/test-wrc20.sh -0.007815 -0.001020
test/regression-wasm/test-loops.sh -0.010052 0.000182

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.090003 -0.000054
test/regression-evm/test-sumTo10.sh -0.254148 0.003350
test/regression-evm/test-pop1.sh -0.058571 0.000054
test/regression-evm/test-add0.sh -0.106516 0.000270
test/regression-evm/test-straight-line-no-invalid.sh -0.056327 0.000017
test/regression-evm/test-sum-to-n.sh -0.005195 0.001179
test/regression-evm/test-straight-line.sh -0.061762 -0.005607
test/regression-evm/test-branching-invalid.sh -0.093542 -0.000039
test/regression-wasm/test-memory.sh -0.003894 0.000715
test/regression-wasm/test-simple-arithmetic.sh -0.001158 0.000385
test/regression-wasm/test-locals.sh 0.001566 0.000369
test/regression-wasm/test-wrc20.sh -0.003788 0.028756
test/regression-wasm/test-loops.sh -0.007627 0.000246

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.090015 -0.000054
test/regression-evm/test-sumTo10.sh -0.254184 0.005018
test/regression-evm/test-pop1.sh -0.058574 0.000054
test/regression-evm/test-add0.sh -0.106548 0.000054
test/regression-evm/test-straight-line-no-invalid.sh -0.056323 0.000017
test/regression-evm/test-sum-to-n.sh -0.005585 0.001225
test/regression-evm/test-straight-line.sh -0.061765 0.000023
test/regression-evm/test-branching-invalid.sh -0.093576 0.000011
test/regression-wasm/test-memory.sh -0.004187 0.000716
test/regression-wasm/test-simple-arithmetic.sh -0.001263 0.000317
test/regression-wasm/test-locals.sh 0.001591 0.000372
test/regression-wasm/test-wrc20.sh -0.003949 0.011916
test/regression-wasm/test-loops.sh -0.008135 0.000246

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.038689 -0.000054
test/regression-evm/test-sumTo10.sh -0.130263 -0.007523
test/regression-evm/test-pop1.sh -0.025542 0.000054
test/regression-evm/test-add0.sh -0.051965 0.000054
test/regression-evm/test-straight-line-no-invalid.sh -0.022254 0.000017
test/regression-evm/test-sum-to-n.sh -0.001335 0.003715
test/regression-evm/test-straight-line.sh -0.025153 0.000023
test/regression-evm/test-branching-invalid.sh -0.040660 0.000011
test/regression-wasm/test-memory.sh -0.001626 0.000549
test/regression-wasm/test-simple-arithmetic.sh 0.002230 0.000318
test/regression-wasm/test-locals.sh 0.005077 0.000515
test/regression-wasm/test-wrc20.sh -0.000491 0.019949
test/regression-wasm/test-loops.sh -0.007618 0.000005

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.123186 -0.057084
test/regression-evm/test-sumTo10.sh -0.334679 0.002103
test/regression-evm/test-pop1.sh -0.079154 0.000054
test/regression-evm/test-add0.sh -0.141357 0.000054
test/regression-evm/test-straight-line-no-invalid.sh -0.078007 0.000019
test/regression-evm/test-sum-to-n.sh -0.014444 0.004823
test/regression-evm/test-straight-line.sh -0.085130 0.000023
test/regression-evm/test-branching-invalid.sh -0.127775 0.000011
test/regression-wasm/test-memory.sh -0.008385 0.000576
test/regression-wasm/test-simple-arithmetic.sh -0.003945 0.000464
test/regression-wasm/test-locals.sh 0.000382 0.000429
test/regression-wasm/test-wrc20.sh -0.008801 -0.011932
test/regression-wasm/test-loops.sh -0.015131 0.000059

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.122941 -0.000054
test/regression-evm/test-sumTo10.sh -0.334442 0.003141
test/regression-evm/test-pop1.sh -0.079138 0.000054
test/regression-evm/test-add0.sh -0.141315 0.000054
test/regression-evm/test-straight-line-no-invalid.sh -0.077872 0.000017
test/regression-evm/test-sum-to-n.sh -0.012245 0.002560
test/regression-evm/test-straight-line.sh -0.084974 -0.005644
test/regression-evm/test-branching-invalid.sh -0.127566 0.000011
test/regression-wasm/test-memory.sh -0.007788 0.000116
test/regression-wasm/test-simple-arithmetic.sh -0.003799 0.000334
test/regression-wasm/test-locals.sh 0.000386 0.000112
test/regression-wasm/test-wrc20.sh -0.008028 0.026227
test/regression-wasm/test-loops.sh -0.014131 -0.000046

@emarzion emarzion marked this pull request as ready for review June 3, 2021 06:53
@github-actions
Copy link

github-actions bot commented Jun 3, 2021

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh -0.122949 -0.000054
test/regression-evm/test-sumTo10.sh -0.334441 0.003324
test/regression-evm/test-pop1.sh -0.079138 0.000054
test/regression-evm/test-add0.sh -0.141303 0.000054
test/regression-evm/test-straight-line-no-invalid.sh -0.077873 0.000017
test/regression-evm/test-sum-to-n.sh -0.012247 0.003847
test/regression-evm/test-straight-line.sh -0.084993 0.000023
test/regression-evm/test-branching-invalid.sh -0.127560 0.000011
test/regression-wasm/test-memory.sh -0.007707 0.000575
test/regression-wasm/test-simple-arithmetic.sh -0.003774 0.000412
test/regression-wasm/test-locals.sh 0.000429 0.000484
test/regression-wasm/test-wrc20.sh -0.008000 0.005682
test/regression-wasm/test-loops.sh -0.014137 0.000119

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-add0.sh 0.037236 0.000000
test/regression-evm/test-sum-to-n.sh 0.021820 0.164828
test/regression-evm/test-branching-no-invalid.sh 0.034381 0.000000
test/regression-evm/test-straight-line-no-invalid.sh 0.022406 0.000000
test/regression-evm/test-branching-invalid.sh 0.035501 0.000000
test/regression-evm/test-pop1.sh 0.021557 0.000000
test/regression-evm/test-straight-line.sh 0.024088 0.005702
test/regression-evm/test-sumTo10.sh 0.088042 0.039864
test/regression-wasm/test-locals.sh 0.002422 0.000198
test/regression-wasm/test-simple-arithmetic.sh 0.003478 -0.000102
test/regression-wasm/test-wrc20.sh 0.003091 -0.004249
test/regression-wasm/test-loops.sh 0.004420 0.000290
test/regression-wasm/test-memory.sh 0.005576 0.000072

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-add0.sh 0.037268 0.113489
test/regression-evm/test-sum-to-n.sh 0.021822 0.164676
test/regression-evm/test-branching-no-invalid.sh 0.034381 0.000000
test/regression-evm/test-straight-line-no-invalid.sh 0.022406 -0.000000
test/regression-evm/test-branching-invalid.sh 0.035472 0.000000
test/regression-evm/test-pop1.sh 0.021557 0.000000
test/regression-evm/test-straight-line.sh 0.024088 0.000000
test/regression-evm/test-sumTo10.sh 0.088042 0.000004
test/regression-wasm/test-locals.sh 0.002422 0.000196
test/regression-wasm/test-simple-arithmetic.sh 0.003475 -0.000103
test/regression-wasm/test-wrc20.sh 0.003092 -0.003822
test/regression-wasm/test-loops.sh 0.004439 0.000289
test/regression-wasm/test-memory.sh 0.005579 0.000071

@ana-pantilie ana-pantilie requested review from ana-pantilie and removed request for ana-pantilie July 20, 2021 15:01
@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-add0.sh 0.037221 0.000000
test/regression-evm/test-sum-to-n.sh 0.021821 0.000000
test/regression-evm/test-branching-no-invalid.sh 0.034392 -0.000037
test/regression-evm/test-straight-line-no-invalid.sh 0.022421 0.000000
test/regression-evm/test-branching-invalid.sh 0.035472 0.000038
test/regression-evm/test-pop1.sh 0.021525 0.000000
test/regression-evm/test-straight-line.sh 0.024089 0.005702
test/regression-evm/test-sumTo10.sh 0.088052 0.037246
test/regression-wasm/test-locals.sh 0.002435 0.000141
test/regression-wasm/test-simple-arithmetic.sh 0.003465 0.000011
test/regression-wasm/test-wrc20.sh 0.003093 -0.000127
test/regression-wasm/test-loops.sh 0.004406 0.000096
test/regression-wasm/test-memory.sh 0.005572 0.000127

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-add0.sh 0.037236 0.000000
test/regression-evm/test-sum-to-n.sh 0.021819 0.000000
test/regression-evm/test-branching-no-invalid.sh 0.034391 0.000000
test/regression-evm/test-straight-line-no-invalid.sh 0.022421 0.000000
test/regression-evm/test-branching-invalid.sh 0.035497 0.000000
test/regression-evm/test-pop1.sh 0.021562 0.000000
test/regression-evm/test-straight-line.sh 0.024089 0.000000
test/regression-evm/test-sumTo10.sh 0.088052 0.039498
test/regression-wasm/test-locals.sh 0.002435 0.000141
test/regression-wasm/test-simple-arithmetic.sh 0.003467 0.000010
test/regression-wasm/test-wrc20.sh 0.003097 -0.001772
test/regression-wasm/test-loops.sh 0.004414 0.000096
test/regression-wasm/test-memory.sh 0.005556 0.000127

Copy link
Contributor

@ana-pantilie ana-pantilie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the tests are consistently slower, when I think we were expecting a speed-up. Could you investigate?

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-add0.sh 0.037514 0.000000
test/regression-evm/test-sum-to-n.sh 0.022093 0.000000
test/regression-evm/test-branching-no-invalid.sh 0.034666 0.000000
test/regression-evm/test-straight-line-no-invalid.sh 0.022630 0.000000
test/regression-evm/test-branching-invalid.sh 0.035776 0.000000
test/regression-evm/test-pop1.sh 0.021763 0.000001
test/regression-evm/test-straight-line.sh 0.024320 0.005702
test/regression-evm/test-sumTo10.sh 0.088222 0.034259
test/regression-wasm/test-locals.sh 0.002473 0.000077
test/regression-wasm/test-simple-arithmetic.sh 0.003527 0.000054
test/regression-wasm/test-wrc20.sh 0.003180 -0.000616
test/regression-wasm/test-loops.sh 0.004497 -0.000081
test/regression-wasm/test-memory.sh 0.005683 -0.000039

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-add0.sh 0.039076 0.000000
test/regression-evm/test-sum-to-n.sh 0.022347 0.000001
test/regression-evm/test-branching-no-invalid.sh 0.036023 0.000000
test/regression-evm/test-straight-line-no-invalid.sh 0.023190 0.000000
test/regression-evm/test-branching-invalid.sh 0.037198 0.000000
test/regression-evm/test-pop1.sh 0.022277 0.000000
test/regression-evm/test-straight-line.sh 0.024970 0.000000
test/regression-evm/test-sumTo10.sh 0.097691 -0.002198
test/regression-wasm/test-locals.sh 0.002474 0.000078
test/regression-wasm/test-simple-arithmetic.sh 0.003545 0.000054
test/regression-wasm/test-wrc20.sh 0.003187 -0.005011
test/regression-wasm/test-loops.sh 0.004516 -0.000082
test/regression-wasm/test-memory.sh 0.005693 -0.000040

@ana-pantilie ana-pantilie removed the request for review from MirceaS July 29, 2021 14:40
Copy link
Contributor

@ana-pantilie ana-pantilie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard comment if it doesn't make sense.

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.014546 -0.026511
test/regression-evm/test-straight-line.sh 0.007299 0.035457
test/regression-evm/test-straight-line-no-invalid.sh 0.006042 -0.006430
test/regression-evm/test-branching-invalid.sh 0.013328 -0.021883
test/regression-evm/test-sum-to-n.sh 0.008446 0.010423
test/regression-evm/test-branching-no-invalid.sh 0.012259 -0.001263
test/regression-evm/test-add0.sh 0.023354 0.009889
test/regression-evm/test-sumTo10.sh 0.073099 0.000218
test/regression-wasm/test-memory.sh 0.006138 -0.000000
test/regression-wasm/test-locals.sh 0.002666 0.000001
test/regression-wasm/test-wrc20.sh 0.003267 0.000687
test/regression-wasm/test-loops.sh 0.005003 0.000001
test/regression-wasm/test-simple-arithmetic.sh 0.003885 0.000001

@github-actions
Copy link

github-actions bot commented Aug 4, 2021

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.014485 -0.006181
test/regression-evm/test-straight-line.sh 0.007262 0.007885
test/regression-evm/test-straight-line-no-invalid.sh 0.006015 -0.000425
test/regression-evm/test-branching-invalid.sh 0.013276 -0.005295
test/regression-evm/test-sum-to-n.sh 0.008428 -0.008508
test/regression-evm/test-branching-no-invalid.sh 0.012214 0.012799
test/regression-evm/test-add0.sh 0.023275 0.019072
test/regression-evm/test-sumTo10.sh 0.073118 -0.007522
test/regression-wasm/test-memory.sh 0.006066 -0.000194
test/regression-wasm/test-locals.sh 0.002628 -0.000196
test/regression-wasm/test-wrc20.sh 0.003250 -0.004878
test/regression-wasm/test-loops.sh 0.004968 -0.000197
test/regression-wasm/test-simple-arithmetic.sh 0.003803 0.000029

@github-actions
Copy link

github-actions bot commented Aug 5, 2021

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.014485 -0.005744
test/regression-evm/test-straight-line.sh 0.007262 0.007886
test/regression-evm/test-straight-line-no-invalid.sh 0.006017 -0.006239
test/regression-evm/test-branching-invalid.sh 0.013276 -0.005295
test/regression-evm/test-sum-to-n.sh 0.008427 0.005928
test/regression-evm/test-branching-no-invalid.sh 0.012214 0.012799
test/regression-evm/test-add0.sh 0.023275 0.019072
test/regression-evm/test-sumTo10.sh 0.073118 -0.009679
test/regression-wasm/test-memory.sh 0.006091 -0.000195
test/regression-wasm/test-locals.sh 0.002628 -0.000195
test/regression-wasm/test-wrc20.sh 0.003266 -0.013909
test/regression-wasm/test-loops.sh 0.004948 -0.000198
test/regression-wasm/test-simple-arithmetic.sh 0.003782 -0.000227

@github-actions
Copy link

github-actions bot commented Aug 5, 2021

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.014485 -0.005744
test/regression-evm/test-straight-line.sh 0.007263 0.012845
test/regression-evm/test-straight-line-no-invalid.sh 0.006017 -0.000833
test/regression-evm/test-branching-invalid.sh 0.013276 -0.005295
test/regression-evm/test-sum-to-n.sh 0.008432 -0.001606
test/regression-evm/test-branching-no-invalid.sh 0.012213 0.012799
test/regression-evm/test-add0.sh 0.023275 0.019072
test/regression-evm/test-sumTo10.sh 0.073118 -0.006902
test/regression-wasm/test-memory.sh 0.006077 -0.000194
test/regression-wasm/test-locals.sh 0.002628 -0.000196
test/regression-wasm/test-wrc20.sh 0.003246 0.022014
test/regression-wasm/test-loops.sh 0.004918 -0.000198
test/regression-wasm/test-simple-arithmetic.sh 0.003811 0.000093

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.014485 0.003933
test/regression-evm/test-straight-line.sh 0.007263 0.007884
test/regression-evm/test-straight-line-no-invalid.sh 0.006016 -0.000832
test/regression-evm/test-branching-invalid.sh 0.013276 0.005158
test/regression-evm/test-sum-to-n.sh 0.008431 -0.001606
test/regression-evm/test-branching-no-invalid.sh 0.012213 0.014352
test/regression-evm/test-add0.sh 0.023275 0.019072
test/regression-evm/test-sumTo10.sh 0.073118 -0.007522
test/regression-wasm/test-memory.sh 0.006096 -0.000194
test/regression-wasm/test-locals.sh 0.002627 -0.000196
test/regression-wasm/test-wrc20.sh 0.003262 -0.015276
test/regression-wasm/test-loops.sh 0.004950 -0.000200
test/regression-wasm/test-simple-arithmetic.sh 0.003852 -0.000090

@ana-pantilie ana-pantilie merged commit eefb9b4 into master Aug 6, 2021
@ana-pantilie ana-pantilie deleted the unification-refactor3 branch August 6, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimize unification inner loop

4 participants