Skip to content

Conversation

@ttuegel
Copy link
Contributor

@ttuegel ttuegel commented Jun 16, 2021

See this comment.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ttuegel ttuegel requested a review from ana-pantilie June 16, 2021 15:23
@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh 0 0
test/regression-evm/test-sumTo10.sh 0.000000 0.005247
test/regression-evm/test-pop1.sh -0.000000 0
test/regression-evm/test-add0.sh -0.000009 0
test/regression-evm/test-straight-line-no-invalid.sh -0.000000 0
test/regression-evm/test-sum-to-n.sh 0.000002 0.000447
test/regression-evm/test-straight-line.sh -0.000001 0
test/regression-evm/test-branching-invalid.sh 0.000005 0.000035
test/regression-wasm/test-memory.sh -0.000010 0.000001
test/regression-wasm/test-simple-arithmetic.sh 0.000010 -0.000001
test/regression-wasm/test-locals.sh 0.000000 0
test/regression-wasm/test-wrc20.sh -0.000007 -0.000448
test/regression-wasm/test-loops.sh -0.000023 -0.000001

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-straight-line-no-invalid.sh 0.000000 0
test/regression-evm/test-straight-line.sh 0 0
test/regression-evm/test-branching-no-invalid.sh 0.000000 0
test/regression-evm/test-add0.sh -0.000000 0
test/regression-evm/test-sum-to-n.sh 0.000000 -0.000382
test/regression-evm/test-sumTo10.sh 0.000000 -0.000386
test/regression-evm/test-pop1.sh 0.000016 0
test/regression-evm/test-branching-invalid.sh -0.000016 0
test/regression-wasm/test-loops.sh 0.000003 0.000000
test/regression-wasm/test-wrc20.sh 0.000000 -0.000290
test/regression-wasm/test-locals.sh -0.000000 0
test/regression-wasm/test-simple-arithmetic.sh -0.000006 0.000000
test/regression-wasm/test-memory.sh -0.000004 0

@rv-jenkins rv-jenkins merged commit c42cec6 into master Jun 18, 2021
@rv-jenkins rv-jenkins deleted the inconsistent-prelude-test branch June 18, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants