Skip to content

Conversation

@ttuegel
Copy link
Contributor

@ttuegel ttuegel commented Jun 16, 2021

This pull request will clean up the merge after #2599.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-branching-no-invalid.sh 0.041436 -0.000000
test/regression-evm/test-sumTo10.sh -0.013675 -0.000964
test/regression-evm/test-pop1.sh 0.055733 -0.000000
test/regression-evm/test-add0.sh 0.040131 -0.000000
test/regression-evm/test-straight-line-no-invalid.sh 0.054097 -0.000000
test/regression-evm/test-sum-to-n.sh -0.030953 -0.000464
test/regression-evm/test-straight-line.sh 0.052456 -0.000000
test/regression-evm/test-branching-invalid.sh 0.040334 -0.000000
test/regression-wasm/test-memory.sh 0.053157 -0.000315
test/regression-wasm/test-simple-arithmetic.sh 0.089710 -0.000809
test/regression-wasm/test-locals.sh 0.106060 -0.000286
test/regression-wasm/test-wrc20.sh 0.004986 -0.000374
test/regression-wasm/test-loops.sh 0.025439 -0.000219

@ttuegel ttuegel force-pushed the overhaul-predicate-cleanup branch from 2263192 to f82bd67 Compare June 18, 2021 16:53
@ttuegel ttuegel marked this pull request as ready for review June 18, 2021 16:54
@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-straight-line-no-invalid.sh -0.001296 0.060869
test/regression-evm/test-straight-line.sh -0.001298 0
test/regression-evm/test-branching-no-invalid.sh -0.001252 0
test/regression-evm/test-add0.sh -0.001227 0
test/regression-evm/test-sum-to-n.sh -0.001454 -0.000062
test/regression-evm/test-sumTo10.sh -0.000759 -0.000717
test/regression-evm/test-pop1.sh -0.001308 0
test/regression-evm/test-branching-invalid.sh -0.001237 -0.000000
test/regression-wasm/test-loops.sh -0.001597 -0.000058
test/regression-wasm/test-wrc20.sh -0.001192 -0.000195
test/regression-wasm/test-locals.sh -0.001871 -0.000072
test/regression-wasm/test-simple-arithmetic.sh -0.001847 -0.000106
test/regression-wasm/test-memory.sh -0.001619 -0.000192

@ttuegel ttuegel merged commit 7eca7c4 into master Jun 21, 2021
@ttuegel ttuegel deleted the overhaul-predicate-cleanup branch June 21, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants