Skip to content

Conversation

@ana-pantilie
Copy link
Contributor

Fixes an issue discovered while working on #2767.


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ana-pantilie ana-pantilie mentioned this pull request Aug 10, 2021
4 tasks
@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.000487 -0.010816
test/regression-evm/test-straight-line.sh 0.000505 0.000765
test/regression-evm/test-straight-line-no-invalid.sh 0.000500 -0.001911
test/regression-evm/test-branching-invalid.sh 0.000527 -0.011180
test/regression-evm/test-sum-to-n.sh 0.000782 0.121851
test/regression-evm/test-branching-no-invalid.sh 0.000524 -0.001506
test/regression-evm/test-add0.sh 0.000497 -0.019683
test/regression-evm/test-sumTo10.sh 0.000579 -0.001440
test/regression-wasm/test-memory.sh 0.001588 0.000001
test/regression-wasm/test-locals.sh 0.001362 -0.000025
test/regression-wasm/test-wrc20.sh 0.001099 -0.012154
test/regression-wasm/test-loops.sh 0.001369 0.000007
test/regression-wasm/test-simple-arithmetic.sh 0.001301 -0.000256

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.000487 -0.010444
test/regression-evm/test-straight-line.sh 0.000505 0.000766
test/regression-evm/test-straight-line-no-invalid.sh 0.000500 -0.001912
test/regression-evm/test-branching-invalid.sh 0.000526 -0.016650
test/regression-evm/test-sum-to-n.sh 0.000773 0.008932
test/regression-evm/test-branching-no-invalid.sh 0.000524 -0.010844
test/regression-evm/test-add0.sh 0.000499 -0.019269
test/regression-evm/test-sumTo10.sh 0.000579 0.001630
test/regression-wasm/test-memory.sh 0.001610 0.000003
test/regression-wasm/test-locals.sh 0.001362 -0.000025
test/regression-wasm/test-wrc20.sh 0.001115 0.002933
test/regression-wasm/test-loops.sh 0.001380 0.000005
test/regression-wasm/test-simple-arithmetic.sh 0.001308 0.000012

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.000487 -0.010445
test/regression-evm/test-straight-line.sh 0.000505 0.004940
test/regression-evm/test-straight-line-no-invalid.sh 0.000500 -0.001912
test/regression-evm/test-branching-invalid.sh 0.000526 -0.011179
test/regression-evm/test-sum-to-n.sh 0.000776 0.032497
test/regression-evm/test-branching-no-invalid.sh 0.000523 0.000548
test/regression-evm/test-add0.sh 0.000499 -0.019269
test/regression-evm/test-sumTo10.sh 0.000579 0.001613
test/regression-wasm/test-memory.sh 0.001615 0.000000
test/regression-wasm/test-locals.sh 0.001362 -0.000024
test/regression-wasm/test-wrc20.sh 0.001102 -0.006248
test/regression-wasm/test-loops.sh 0.001380 0.000005
test/regression-wasm/test-simple-arithmetic.sh 0.001404 -0.000081

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.000487 -0.006373
test/regression-evm/test-straight-line.sh 0.000505 0.005763
test/regression-evm/test-straight-line-no-invalid.sh 0.000500 -0.001912
test/regression-evm/test-branching-invalid.sh 0.000527 -0.011179
test/regression-evm/test-sum-to-n.sh 0.000776 0.008932
test/regression-evm/test-branching-no-invalid.sh 0.000524 -0.001506
test/regression-evm/test-add0.sh 0.000497 -0.015464
test/regression-evm/test-sumTo10.sh 0.000579 0.001384
test/regression-wasm/test-memory.sh 0.001601 0.000000
test/regression-wasm/test-locals.sh 0.001362 -0.000023
test/regression-wasm/test-wrc20.sh 0.001103 -0.002580
test/regression-wasm/test-loops.sh 0.001365 0.000004
test/regression-wasm/test-simple-arithmetic.sh 0.001396 0.000252

Copy link
Contributor

@dopamane dopamane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

-- accordingly.
simplifyTerm term
| Right predicate <- Predicate.makePredicate term =
toOrPattern (termLikeSort term) <$> worker predicate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could add documentation for the worker function?

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.000487 -0.006371
test/regression-evm/test-straight-line.sh 0.000505 0.004939
test/regression-evm/test-straight-line-no-invalid.sh 0.000475 0.009462
test/regression-evm/test-branching-invalid.sh 0.000518 0.002539
test/regression-evm/test-sum-to-n.sh 0.000777 0.008932
test/regression-evm/test-branching-no-invalid.sh 0.000524 -0.006312
test/regression-evm/test-add0.sh 0.000499 -0.019270
test/regression-evm/test-sumTo10.sh 0.000579 -0.000222
test/regression-wasm/test-memory.sh 0.001643 0.000001
test/regression-wasm/test-locals.sh 0.001362 -0.000024
test/regression-wasm/test-wrc20.sh 0.001095 -0.000086
test/regression-wasm/test-loops.sh 0.001375 0.000003
test/regression-wasm/test-simple-arithmetic.sh 0.001348 0.000006

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-pop1.sh 0.000484 -0.002232
test/regression-evm/test-straight-line.sh 0.000505 0.000018
test/regression-evm/test-straight-line-no-invalid.sh 0.000500 -0.001912
test/regression-evm/test-branching-invalid.sh 0.000527 -0.011179
test/regression-evm/test-sum-to-n.sh 0.000773 0.049387
test/regression-evm/test-branching-no-invalid.sh 0.000523 -0.010845
test/regression-evm/test-add0.sh 0.000499 -0.019269
test/regression-evm/test-sumTo10.sh 0.000578 0.001598
test/regression-wasm/test-memory.sh 0.001610 -0.000001
test/regression-wasm/test-locals.sh 0.001363 -0.000025
test/regression-wasm/test-wrc20.sh 0.001119 0.018101
test/regression-wasm/test-loops.sh 0.001395 0.000004
test/regression-wasm/test-simple-arithmetic.sh 0.001345 -0.000081

@rv-jenkins rv-jenkins merged commit c1b298e into master Aug 13, 2021
@rv-jenkins rv-jenkins deleted the fix-predicate-simplifier-term-simplification branch August 13, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants