-
Notifications
You must be signed in to change notification settings - Fork 43
Fix Predicate simplifier sub-TermLike simplification
#2796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rv-jenkins
merged 7 commits into
master
from
fix-predicate-simplifier-term-simplification
Aug 13, 2021
Merged
Fix Predicate simplifier sub-TermLike simplification
#2796
rv-jenkins
merged 7 commits into
master
from
fix-predicate-simplifier-term-simplification
Aug 13, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
|
|
|
dopamane
approved these changes
Aug 12, 2021
Contributor
dopamane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| -- accordingly. | ||
| simplifyTerm term | ||
| | Right predicate <- Predicate.makePredicate term = | ||
| toOrPattern (termLikeSort term) <$> worker predicate |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could add documentation for the worker function?
|
andreiburdusa
approved these changes
Aug 13, 2021
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue discovered while working on #2767.
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.