LTS Haskell 18.18 #2924
Merged
LTS Haskell 18.18 #2924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
andreiburdusa
force-pushed
the
update-resolver-lts-18.18
branch
from
c9cdea3 to
90a85e7
Compare
|
|
|
…e into update-resolver-lts-18.18
|
|
|
|
This reverts commit 5557f7f.
…e into update-resolver-lts-18.18
|
|
|
|
|
|
|
|
|
ana-pantilie
approved these changes
Dec 14, 2021
Contributor
ana-pantilie
left a comment
ana-pantilie
left a comment
There was a problem hiding this comment.
👍 Also, thanks for writing down the detailed description!
dopamane
approved these changes
Dec 14, 2021
Contributor
dopamane
left a comment
dopamane
left a comment
There was a problem hiding this comment.
Tested out nix-shell and nix-build successfully. I had to increase ulimit on my local machine for nix-build test.nix to avoid a too many open files error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2932
tasty-test-reporter, but that version doesn't work for the new resolver. I think it's safe to use the original package because Tom's commitsprintSummary: Respect terminal color settingandprintLines: Defer decision about printing with colorfrom his fork are also present in the original repository. I also didn't see a color difference when running the unit tests. Therefore I removed the link to his repository fromextra-depsinstack.yaml.co-logto>=0.4was not enough to make the build succeed, so I added it's precise version toextra-depsinstack.yaml.sources.jsonwas updated usingNivnix-haskell-hlsbecamehaskell-hls-nixand it had to be givenghcVersion"8.10.7"instead ofcompiler-nix-name"ghc8107"Many changes were automatically made during the build process or by running
./nix/rematerialize.sh.Things that took me a lot to figure out:
index-stateindefault.nixnivwhich branch ofhlintto use in order to update to a newer versionScope: haskell-language-server is not supported anymore for GHC 8.10.4
Estimate: December 14
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.