Skip to content

Conversation

@ana-pantilie
Copy link
Contributor

@ana-pantilie ana-pantilie commented Dec 10, 2021

Fixes #2939

Scope:

  • adds infrastructure for enabling and disabling the experimental simplifier from the command line
  • cleans up executables and Test.Kore.Exec a bit
  • adds convenience targets to the Makefile in kore/kore
  • adds new targets to Makefiles which facilitate running the integration tests with the option turned on

Estimate:

  • Tuesday 14th December 2021

Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

@ana-pantilie ana-pantilie marked this pull request as ready for review December 14, 2021 16:54
@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-storagevar03.sh 0.000882 -0.018236
test/regression-evm/test-straight-line-no-invalid.sh 0.000036 -0.008790
test/regression-evm/test-totalSupply.sh 0.000539 -0.005204
test/regression-evm/test-and0.sh -0.000218 -0.069949
test/regression-evm/test-sumTo10.sh 0.000241 -0.027823
test/regression-evm/test-pop1.sh -0.000294 0.012250
test/regression-evm/test-branching-invalid.sh 0.000066 -0.003910
test/regression-evm/test-lemmas.sh 0.000783 -0.017447
test/regression-evm/test-straight-line.sh 0.000046 0.015666
test/regression-evm/test-sum-to-n.sh 0.000209 -0.002264
test/regression-evm/test-addu48u48.sh 0.000596 -0.011310
test/regression-evm/test-sha3_bigSize.sh -0.000258 -0.104039
test/regression-evm/test-dsvalue-peek-pass-rough.sh 0.000642 -0.023036
test/regression-evm/test-add0.sh -0.000217 -0.006965
test/regression-evm/test-mul0.sh -0.000210 -0.001784
test/regression-evm/test-branching-no-invalid.sh 0.000063 -0.022812
test/regression-wasm/test-memory.sh 0.000561 -0.045087
test/regression-wasm/test-locals.sh 0.000222 -0.044917
test/regression-wasm/test-loops.sh 0.000704 -0.045150
test/regression-wasm/test-simple-arithmetic.sh 0.000281 -0.044974
test/regression-wasm/test-wrc20.sh 0.001064 -0.039058

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-storagevar03.sh 0.000882 -0.024096
test/regression-evm/test-straight-line-no-invalid.sh 0.000036 0.000482
test/regression-evm/test-totalSupply.sh 0.000544 0.013872
test/regression-evm/test-and0.sh -0.000218 -0.080927
test/regression-evm/test-sumTo10.sh 0.000242 -0.020691
test/regression-evm/test-pop1.sh -0.000294 0.026097
test/regression-evm/test-branching-invalid.sh 0.000066 0.104499
test/regression-evm/test-lemmas.sh 0.000777 -0.007215
test/regression-evm/test-straight-line.sh 0.000045 -0.064358
test/regression-evm/test-sum-to-n.sh 0.000214 -0.006625
test/regression-evm/test-addu48u48.sh 0.000600 0.103644
test/regression-evm/test-sha3_bigSize.sh -0.000259 0.017019
test/regression-evm/test-dsvalue-peek-pass-rough.sh 0.000675 0.100238
test/regression-evm/test-add0.sh -0.000216 0.075627
test/regression-evm/test-mul0.sh -0.000210 -0.029319
test/regression-evm/test-branching-no-invalid.sh 0.000063 -0.052878
test/regression-wasm/test-memory.sh 0.000531 -0.045099
test/regression-wasm/test-locals.sh 0.000221 -0.044898
test/regression-wasm/test-loops.sh 0.000679 -0.044866
test/regression-wasm/test-simple-arithmetic.sh 0.000310 -0.044973
test/regression-wasm/test-wrc20.sh 0.000998 -0.046025

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-storagevar03.sh 0.000881 -0.021014
test/regression-evm/test-straight-line-no-invalid.sh 0.000036 -0.035435
test/regression-evm/test-totalSupply.sh 0.000540 -0.013889
test/regression-evm/test-and0.sh -0.000218 0.016615
test/regression-evm/test-sumTo10.sh 0.000242 -0.024266
test/regression-evm/test-pop1.sh -0.000294 0.012268
test/regression-evm/test-branching-invalid.sh 0.000066 -0.003926
test/regression-evm/test-lemmas.sh 0.000774 -0.019732
test/regression-evm/test-straight-line.sh 0.000046 0.038951
test/regression-evm/test-sum-to-n.sh 0.000206 -0.006553
test/regression-evm/test-addu48u48.sh 0.000597 -0.107195
test/regression-evm/test-sha3_bigSize.sh -0.000259 -0.036863
test/regression-evm/test-dsvalue-peek-pass-rough.sh 0.000636 0.018316
test/regression-evm/test-add0.sh -0.000216 -0.071676
test/regression-evm/test-mul0.sh -0.000210 -0.015871
test/regression-evm/test-branching-no-invalid.sh 0.000063 -0.022814
test/regression-wasm/test-memory.sh 0.000552 -0.045098
test/regression-wasm/test-locals.sh 0.000220 -0.044898
test/regression-wasm/test-loops.sh 0.000686 -0.045158
test/regression-wasm/test-simple-arithmetic.sh 0.000251 -0.044973
test/regression-wasm/test-wrc20.sh 0.001056 -0.049380

@github-actions
Copy link

name diff_allocated_bytes diff_max_live_bytes
test/regression-evm/test-storagevar03.sh 0.000204 -0.003003
test/regression-evm/test-straight-line-no-invalid.sh 0.000075 -0.035714
test/regression-evm/test-totalSupply.sh 0.000143 -0.001594
test/regression-evm/test-and0.sh 0.000123 -0.004501
test/regression-evm/test-sumTo10.sh 0.000296 0.003615
test/regression-evm/test-pop1.sh 0.000097 0.005674
test/regression-evm/test-branching-invalid.sh 0.000098 -0.008396
test/regression-evm/test-lemmas.sh 0.000126 0.000331
test/regression-evm/test-straight-line.sh 0.000079 0.093697
test/regression-evm/test-sum-to-n.sh 0.000110 0.005927
test/regression-evm/test-addu48u48.sh 0.000188 -0.002514
test/regression-evm/test-sha3_bigSize.sh 0.000100 0.045038
test/regression-evm/test-dsvalue-peek-pass-rough.sh 0.000100 -0.104646
test/regression-evm/test-add0.sh 0.000124 -0.021866
test/regression-evm/test-mul0.sh 0.000125 -0.070310
test/regression-evm/test-branching-no-invalid.sh 0.000096 -0.008065
test/regression-wasm/test-memory.sh 0.000179 -0.000016
test/regression-wasm/test-locals.sh 0.000149 -0.000073
test/regression-wasm/test-loops.sh 0.000117 -0.000028
test/regression-wasm/test-simple-arithmetic.sh 0.000153 0.000022
test/regression-wasm/test-wrc20.sh 0.000212 -0.004182

@ana-pantilie ana-pantilie merged commit 96c6f44 into master Dec 16, 2021
@ana-pantilie ana-pantilie deleted the add-simplifierx-infrastructure branch December 16, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add infrastructure for experimental simplifier

5 participants