EXPERIMENT: refactor graph traversal to replace leavesM
#3163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red-leaf-count-refactor-leavesM * Simplifier as a base monad
Semantics of TraversalResult (failure cases): - When `GotStuck` is returned, the returned results are considered stuck and thrown as an exception; - when `Aborted` is returned, the returned results are _analysed_ and their _next_ states (to enqueue) are considered stuck and thrown.
jberthold
changed the title
leavesM
Member
Author
|
Performance gain is currently around 1% across the kevm proofs.
|
jberthold
commented
Jul 22, 2022
jberthold
commented
Jul 22, 2022
jberthold
commented
Jul 22, 2022
| <$> runTransitionT (applyGroup is config) | ||
|
|
||
| applyGroup :: Step -> config -> TransitionT rule m config | ||
| applyGroup is c = foldM (flip applyPrim) c is |
Member
Author
There was a problem hiding this comment.
This seems to be a problem with cabal but not with stack - we should consolidate dependency versions more thoroughly IMHO
Member
Author
There was a problem hiding this comment.
I added import Control.Monad(foldM) to make cabal happy again.
jberthold
commented
Jul 22, 2022
| debugBeforeTransition, | ||
| debugFinalTransition, | ||
| ) | ||
| import Kore.Log.InfoExecBreadth |
Member
Author
There was a problem hiding this comment.
Needs to be added to the GraphTraversal where the queue operation now lives.
…red-leaf-count-refactor-leavesM
jberthold
force-pushed
the
3119-output-unexplored-leaf-count-refactor-leavesM
branch
from
0ae648e to
b79fa99
Compare
jberthold
force-pushed
the
3119-output-unexplored-leaf-count-refactor-leavesM
branch
from
b08902c to
3719858
Compare
|
Member
Author
|
When using
|
|
|
|
|
Member
Author
|
Replaced by #3168 |
jberthold
deleted the
3119-output-unexplored-leaf-count-refactor-leavesM
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #3119
Scope:
A more integrated version of
leavesMalong its use inproveClaim, describing different return values as data instead of using exceptions.We could further monomorphise it to use the simplifier monad (including logging) at the bottom of the monad stack.
Estimate:
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.