Implement --smt-retry-limit option #3166
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3162
Scope:
Add a new option,
--smt-retry-limit, which controls how many times we will retry an SMT query that returnedUnknown. Previously, we would always retry once.Estimate:
I think it's done already, but it's unclear where tests for this feature should go (or even if there should be any, as retries were previously untested anyway).
Review checklist
The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.