Skip to content

Conversation

@jberthold
Copy link
Member

Also aligned the order of dependencies in kore-ghc8107.nix.d/default.nix and kore-ghc923.nix.d/default.nix to make comparisons easier.

Fixes ghc-9.2.3 build

Scope:

Estimate:


Review checklist

The author performs the actions on the checklist. The reviewer evaluates the work and checks the boxes as they are completed.

  • Summary. Write a summary of the changes. Explain what you did to fix the issue, and why you did it. Present the changes in a logical order. Instead of writing a summary in the pull request, you may push a clean Git history.
  • Documentation. Write documentation for new functions. Update documentation for functions that changed, or complete documentation where it is missing.
  • Tests. Write unit tests for every change. Write the unit tests that were missing before the changes. Include any examples from the reported issue as integration tests.
  • Clean up. The changes are already clean. Clean up anything near the changes that you noticed while working. This does not mean only spatially near the changes, but logically near: any code that interacts with the changes!

Also aligned the order of dependencies in
`kore-ghc8107.nix.d/default.nix` and `kore-ghc923.nix.d/default.nix`
to make comparisons easier.
Comment on lines 14 to 20
"ghc-events" = (((hackage.ghc-events)."0.17.0.3").revisions).default;
"tasty-test-reporter" =
(((hackage.tasty-test-reporter)."0.1.1.4").revisions).default;
"junit-xml" = (((hackage.junit-xml)."0.1.0.0").revisions).default;
"compact" = (((hackage.compact)."0.2.0.0").revisions).default;
"decision-diagrams" =
(((hackage.decision-diagrams)."0.2.0.0").revisions).default;
"ghc-events" = (((hackage.ghc-events)."0.17.0.3").revisions).default;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... so, the rematerialise magic seems to disagree here 🤷‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add decision-diagrams to stack-nix-ghc9.yaml first. Nix uses that file to generate nix/kore-ghc923.nix.d/default.nix

@rv-jenkins rv-jenkins merged commit ac0e3c0 into master Aug 4, 2022
@rv-jenkins rv-jenkins deleted the HOTFIX-ghc923-decision-diagrams branch August 4, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants