Return vacuous in kore-rpc when state goes to #bottom
#3637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodlyrottenapple
changed the title
kore-rpc when state goes to #bottom
jberthold
reviewed
Aug 8, 2023
…he GotStuck of TraversalResult
geo2a
approved these changes
Aug 9, 2023
This was referenced Aug 11, 2023
goodlyrottenapple
added a commit
that referenced
this pull request
Sep 7, 2023
Fix for change introduced by #3637, wherein branching could contain bottom states which were not being pruned. (see runtimeverification/pyk#634 (comment))
rv-jenkins
pushed a commit
to runtimeverification/pyk
that referenced
this pull request
Sep 8, 2023
With runtimeverification/haskell-backend#3637, kore-rpc returns a new response with a `vacuous` stop reason and the current state before rewriting the state to `#Bottom`. Changes in this PR: - added a new set `vacuous` to the kcfg. The reason to add the set here and not in the `APRProof` is that the response comes from the backend, and is not semantics related. - modified `cterm_execute` to return if the result is vacuous. - modified `extend` to add a `vacuous` node to the kcfg if `cterm_execute` gets a `vacuous` response. - modified `APRProof` and `APRBMCProof` to prevent marking `vacuous` nodes as `pending` or `failing`. - modified proof summaries to include `vacuous`. <img width="827" alt="Screenshot 2023-08-08 at 16 42 48" src="https://github.com/runtimeverification/pyk/assets/16517508/5e20228e-03e0-412f-8fb1-c5f9ac340ad9"> --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Petar Maksimovic <petar.maksimovic@runtimeverification.com> Co-authored-by: Petar Maksimović <PetarMax@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
With runtimeverification/haskell-backend#3637, kore-rpc returns a new response with a `vacuous` stop reason and the current state before rewriting the state to `#Bottom`. Changes in this PR: - added a new set `vacuous` to the kcfg. The reason to add the set here and not in the `APRProof` is that the response comes from the backend, and is not semantics related. - modified `cterm_execute` to return if the result is vacuous. - modified `extend` to add a `vacuous` node to the kcfg if `cterm_execute` gets a `vacuous` response. - modified `APRProof` and `APRBMCProof` to prevent marking `vacuous` nodes as `pending` or `failing`. - modified proof summaries to include `vacuous`. <img width="827" alt="Screenshot 2023-08-08 at 16 42 48" src="https://github.com/runtimeverification/pyk/assets/16517508/5e20228e-03e0-412f-8fb1-c5f9ac340ad9"> --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Petar Maksimovic <petar.maksimovic@runtimeverification.com> Co-authored-by: Petar Maksimović <PetarMax@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
With runtimeverification/haskell-backend#3637, kore-rpc returns a new response with a `vacuous` stop reason and the current state before rewriting the state to `#Bottom`. Changes in this PR: - added a new set `vacuous` to the kcfg. The reason to add the set here and not in the `APRProof` is that the response comes from the backend, and is not semantics related. - modified `cterm_execute` to return if the result is vacuous. - modified `extend` to add a `vacuous` node to the kcfg if `cterm_execute` gets a `vacuous` response. - modified `APRProof` and `APRBMCProof` to prevent marking `vacuous` nodes as `pending` or `failing`. - modified proof summaries to include `vacuous`. <img width="827" alt="Screenshot 2023-08-08 at 16 42 48" src="https://github.com/runtimeverification/pyk/assets/16517508/5e20228e-03e0-412f-8fb1-c5f9ac340ad9"> --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Petar Maksimovic <petar.maksimovic@runtimeverification.com> Co-authored-by: Petar Maksimović <PetarMax@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 9, 2024
With runtimeverification/haskell-backend#3637, kore-rpc returns a new response with a `vacuous` stop reason and the current state before rewriting the state to `#Bottom`. Changes in this PR: - added a new set `vacuous` to the kcfg. The reason to add the set here and not in the `APRProof` is that the response comes from the backend, and is not semantics related. - modified `cterm_execute` to return if the result is vacuous. - modified `extend` to add a `vacuous` node to the kcfg if `cterm_execute` gets a `vacuous` response. - modified `APRProof` and `APRBMCProof` to prevent marking `vacuous` nodes as `pending` or `failing`. - modified proof summaries to include `vacuous`. <img width="827" alt="Screenshot 2023-08-08 at 16 42 48" src="https://github.com/runtimeverification/pyk/assets/16517508/5e20228e-03e0-412f-8fb1-c5f9ac340ad9"> --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Petar Maksimovic <petar.maksimovic@runtimeverification.com> Co-authored-by: Petar Maksimović <PetarMax@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
With runtimeverification/haskell-backend#3637, kore-rpc returns a new response with a `vacuous` stop reason and the current state before rewriting the state to `#Bottom`. Changes in this PR: - added a new set `vacuous` to the kcfg. The reason to add the set here and not in the `APRProof` is that the response comes from the backend, and is not semantics related. - modified `cterm_execute` to return if the result is vacuous. - modified `extend` to add a `vacuous` node to the kcfg if `cterm_execute` gets a `vacuous` response. - modified `APRProof` and `APRBMCProof` to prevent marking `vacuous` nodes as `pending` or `failing`. - modified proof summaries to include `vacuous`. <img width="827" alt="Screenshot 2023-08-08 at 16 42 48" src="https://github.com/runtimeverification/pyk/assets/16517508/5e20228e-03e0-412f-8fb1-c5f9ac340ad9"> --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Petar Maksimovic <petar.maksimovic@runtimeverification.com> Co-authored-by: Petar Maksimović <PetarMax@users.noreply.github.com>
Baltoli
pushed a commit
to runtimeverification/k
that referenced
this pull request
Apr 10, 2024
With runtimeverification/haskell-backend#3637, kore-rpc returns a new response with a `vacuous` stop reason and the current state before rewriting the state to `#Bottom`. Changes in this PR: - added a new set `vacuous` to the kcfg. The reason to add the set here and not in the `APRProof` is that the response comes from the backend, and is not semantics related. - modified `cterm_execute` to return if the result is vacuous. - modified `extend` to add a `vacuous` node to the kcfg if `cterm_execute` gets a `vacuous` response. - modified `APRProof` and `APRBMCProof` to prevent marking `vacuous` nodes as `pending` or `failing`. - modified proof summaries to include `vacuous`. <img width="827" alt="Screenshot 2023-08-08 at 16 42 48" src="https://github.com/runtimeverification/pyk/assets/16517508/5e20228e-03e0-412f-8fb1-c5f9ac340ad9"> --------- Co-authored-by: devops <devops@runtimeverification.com> Co-authored-by: Petar Maksimovic <petar.maksimovic@runtimeverification.com> Co-authored-by: Petar Maksimović <PetarMax@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at addressing runtimeverification/evm-semantics#1944. Addresses #3630 (needs a follow-up in booster)
This change mimicks what kore-exe in prover mode returns(as introduced by #2451), namely the configuration goes to bottom