Optimize POSet performance#1944
Merged
rv-jenkins merged 3 commits intomasterfrom Apr 27, 2021
Merged
Conversation
Unused
Slightly
dwightguth
approved these changes
Apr 27, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for: #1942
Just by doing this, the test definition drops from 1m30s to 50s
Most of the time is spent in
computeOverloadPOSetfor just one module (around 40s down from 81s).This may indicate that there might be a way to optimize the definition, but the code should be able to handle this in the first place.
Update:
I've exhausted all my quick improvement ideas. This is all I can think of to mitigate the exponential number of productions generated for record productions.
Also, removed the old java implementation of POSet which was not used.