Update parser error messages, second draft#2161
Merged
rv-jenkins merged 3 commits intomasterfrom Aug 25, 2021
Merged
Conversation
radumereuta
approved these changes
Aug 25, 2021
Contributor
radumereuta
left a comment
radumereuta
left a comment
There was a problem hiding this comment.
lgtm
Although Rikard had a comment on slack regarding the usefulness of having more informative error messages with a flag even though parsing might get slower.
ehildenb
approved these changes
Aug 25, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a version of #2157 which has had the "expected" logic stripped out, leaving only the "following token" logic.