Record prods macros#2226
Merged
rv-jenkins merged 4 commits intomasterfrom Sep 28, 2021
Merged
Conversation
- move isMacro to outer.Module - don't generate sort projections for macro symbols - tests
Member
|
Looks good to me, but @dwightguth and @SchmErik should review too. |
SchmErik
approved these changes
Sep 27, 2021
Contributor
SchmErik
left a comment
SchmErik
left a comment
There was a problem hiding this comment.
Looks good to me. I ended up using the macro functions that you wrote in this PR and it works well
| } | ||
| }) | ||
| lazy val rulesFor: Map[KLabel, Set[Rule]] = rules.groupBy(r => matchKLabel(r)) | ||
| lazy val macroKLables: Set[KLabel] = rules.filter(r => r.isMacro).map(r => matchKLabel(r)) |
Contributor
There was a problem hiding this comment.
I've been trying to integrate this code into a separate issue and this code isn't getting the expected result for me. The problem is that rule productions containing macros is a "bubble" rather than a "rule"...
Contributor
There was a problem hiding this comment.
nevermind - this bubble/rule issue is due to me trying to evaluate this logic too early in the kompile pipeline
dwightguth
approved these changes
Sep 28, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2217