Skip to content

Improve checks for format attribute#2358

Merged
dwightguth merged 8 commits intomasterfrom
formatatt
Dec 3, 2021
Merged

Improve checks for format attribute#2358
dwightguth merged 8 commits intomasterfrom
formatatt

Conversation

@dwightguth
Copy link
Copy Markdown
Contributor

Adds errors if:

@dwightguth dwightguth marked this pull request as ready for review December 3, 2021 18:36
Copy link
Copy Markdown
Contributor

@SchmErik SchmErik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dwightguth dwightguth enabled auto-merge (squash) December 3, 2021 19:03

object Sorts {
val Layout = Sort("#Layout")
val LineMarker = Sort("#LineMarker")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see #LineMarker documented in https://kframework.org/USER_MANUAL/. Can you add a blurb there about it (maybe in the same place that #Layout is described).

@dwightguth dwightguth disabled auto-merge December 3, 2021 19:32
@dwightguth dwightguth enabled auto-merge (squash) December 3, 2021 19:51
@dwightguth dwightguth merged commit 3d65e63 into master Dec 3, 2021
@dwightguth dwightguth deleted the formatatt branch December 3, 2021 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[KIP] - Give a proper error message if the user forgets to use the [token]

4 participants