Fix decodeKoreString again#2363
Merged
rv-jenkins merged 10 commits intomasterfrom Dec 13, 2021
Merged
Conversation
ehildenb
approved these changes
Dec 7, 2021
Contributor
Author
|
@dwightguth I would like you to confirm that the current encoding is what the llvm backend expected. And why wasn't there anything failing before? |
Contributor
|
This seems fine, but you should take a look at where this code is called from and make sure it's being adequately tested. |
Member
ehildenb
approved these changes
Dec 13, 2021
Member
|
LGTM, feel free to automerge or wait for more reviews. Thanks for the tests! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2356
I followed the idea from the llvm backend.
I found some differences in encoding though:
LT->-LT-and so on...Please confirm this is the expected behavior.