fix issue where characters are skipped during checking of format att#2380
Merged
rv-jenkins merged 3 commits intomasterfrom Dec 10, 2021
Merged
fix issue where characters are skipped during checking of format att#2380rv-jenkins merged 3 commits intomasterfrom
rv-jenkins merged 3 commits intomasterfrom
Conversation
SchmErik
approved these changes
Dec 10, 2021
ehildenb
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in our code in CheckAtt.java that checked the correctness of the format attribute that caused it to skip over the character immediately following a numerical escape sequence. In the example in the test, this character is another % that escapes a %c, thus leading to the number of %c sequences in the attribute being incorrectly counted. This was due to an omitted adjustment to i when the code was adapted from Formatter.java. We fix this issue and add a test to test that it is correctly fixed.
Fixes #2374