try to address issues with redirecting stdout to file#2404
Merged
rv-jenkins merged 7 commits intomasterfrom Jan 21, 2022
Merged
try to address issues with redirecting stdout to file#2404rv-jenkins merged 7 commits intomasterfrom
rv-jenkins merged 7 commits intomasterfrom
Conversation
radumereuta
previously requested changes
Jan 21, 2022
Member
|
I've tested this against the TEAL semantics and confirmed that it fixes the initial problem. I'd still like to see tests for it (by having a custom |
ehildenb
approved these changes
Jan 21, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously there was a bug where if the user did not specify --output-file to krun, kore-print, or kparse, but nonetheless redirected the output of the command to a file, the file would be truncated even if the user told the shell to append output. This happened because of a particular nuance of how we had been implementing the --output-file flag. This PR should solve this issue by means of adding some extra logic to those scripts. We also take the opportunity to refactor slightly and move some common code into a common script stored in the lib directory that gets sourced by multiple bash scripts.
Fixes #2403