Skip to content

use cached scanner during kprovex#2421

Merged
rv-jenkins merged 2 commits intomasterfrom
kprovex_scanner
Feb 7, 2022
Merged

use cached scanner during kprovex#2421
rv-jenkins merged 2 commits intomasterfrom
kprovex_scanner

Conversation

@dwightguth
Copy link
Copy Markdown
Contributor

No description provided.

@dwightguth dwightguth marked this pull request as ready for review February 2, 2022 16:03
Copy link
Copy Markdown
Contributor

@radumereuta radumereuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing on regression-new, and I can't measure any time improvements.
I did notice the default scanner is not being created anymore though:

regression-new/map-symbolic-tests-haskell$ kprovex assignment-10-spec.k -v
Parse command line options                                   =  0.009s
Outer parsing [68 modules]                                   =  0.401s
  New scanner: ASSIGNMENT-10-SPEC-RULE-CELLS                 =  0.128s
Parse spec modules [1/1 rules]                               =  0.525s
Apply prover steps                                           =  0.185s
Backend                                                      =  0.638s
Cleanup                                                      =  0.045s
Total                                                        =  1.803s

Did you run any tests that indicate this is an improvement?
We also have this issue #2122 which interferes in this case.

@dwightguth
Copy link
Copy Markdown
Contributor Author

I mean, the examples I ran, the scanner only took a couple hundred milliseconds to run, so it's not a very noticeable improvement, but it is there. It will become more meaningful if we reduce other sources of overhead, and it will also be more noticeable on larger definitions.

@dwightguth
Copy link
Copy Markdown
Contributor Author

Any update on this? Should we merge this or just mark the related issue as complete without it?

Copy link
Copy Markdown
Contributor

@radumereuta radumereuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a complete fix but it's an improvement. So let's try it.

@rv-jenkins rv-jenkins merged commit 1cca2ed into master Feb 7, 2022
@rv-jenkins rv-jenkins deleted the kprovex_scanner branch February 7, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants