Refactor pyk AST functions into classes#2448
Merged
rv-jenkins merged 6 commits intomasterfrom Feb 26, 2022
Merged
Conversation
ehildenb
reviewed
Feb 20, 2022
ehildenb
reviewed
Feb 20, 2022
b4f01c7 to
802a7fd
Compare
ehildenb
reviewed
Feb 21, 2022
ehildenb
reviewed
Feb 23, 2022
a669115 to
89df065
Compare
ehildenb
reviewed
Feb 23, 2022
ehildenb
reviewed
Feb 23, 2022
d80a501 to
b283cda
Compare
* Change functions kast.K* to class hierarchy * Remove functions kast.isK* * Remove function kast.KConstant * Remove function kast.getAttribute * Remove function kast.addAttributes * Remove function kast.isCellKLabel * Remove function kastManip.onChildren * Simplify function kastManip.onAttributes * Add mypy check to Makefile
b283cda to
72bcc74
Compare
e012ef3 to
018a52f
Compare
ehildenb
reviewed
Feb 25, 2022
ehildenb
reviewed
Feb 25, 2022
ehildenb
approved these changes
Feb 25, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2447
Fixes: #2444