Add error message for missing start symbol#2847
Merged
rv-jenkins merged 5 commits intodevelopfrom Nov 3, 2022
Merged
Conversation
radumereuta
force-pushed
the
fix2776-kast-miss-sort
branch
from
5efe3ed to
7964301
Compare
dwightguth
reviewed
Oct 20, 2022
|
|
||
|
|
||
| %.kast: kompile | ||
| ifeq ($(TESTDIR),$(RESULTDIR)) |
Contributor
There was a problem hiding this comment.
I don't understand why this target needs to be added.
Contributor
Author
There was a problem hiding this comment.
By default make doesn't check for kast stdout.
So I added the $(CONSIDER_ERRORS) part to the recipe.
I guess this shouldn't be needed if we fix this: #2316
And I'm currently working on it. We may want to delay merging this until then.
Member
|
What's the status of this? Can we merge? |
Contributor
Author
|
I'm waiting for code review. Dwight had a question, and I answered right away. |
ehildenb
reviewed
Nov 3, 2022
ehildenb
approved these changes
Nov 3, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2776
Do not merge.In some runs I got flaky tests which I suspect are from somewhere in kserver.I want to test it a few more times to see it doesn't fail.I haven't seen this fail in a long time so I am making it available for review.