Skip to content

Fix version calculation#2988

Closed
radumereuta wants to merge 2 commits intodevelopfrom
fix2915-version
Closed

Fix version calculation#2988
radumereuta wants to merge 2 commits intodevelopfrom
fix2915-version

Conversation

@radumereuta
Copy link
Copy Markdown
Contributor

Fixes #2915

@radumereuta radumereuta requested a review from Baltoli October 13, 2022 13:27
@rv-jenkins rv-jenkins changed the base branch from master to develop October 13, 2022 13:27
Copy link
Copy Markdown
Contributor

@Baltoli Baltoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking back at #2915, I actually don't think this is the change Tamas requested. His preference is to prefix the short, package, version number with v, but to leave the long format in place even at distance 0 so that the parser can work out where the installation came from. See #2989

@radumereuta
Copy link
Copy Markdown
Contributor Author

Leave it as is. We like to have the hash at the end to know if someone built K from git or got it from a package.

@radumereuta radumereuta deleted the fix2915-version branch October 13, 2022 15:24
radumereuta pushed a commit that referenced this pull request Nov 10, 2022
…2464)

* haskell-backend/src/main/native/haskell-backend: 055af82f0 - Disable kwasm regression tests due to wasm-semantics/#447 (#2986)

* haskell-backend/src/main/native/haskell-backend: fceeb0e8b - Remove anti-left pattern from internal representation of rules (#2989)

* haskell-backend/src/main/native/haskell-backend: ed00c9944 - Add note on LLVM 12 (#2988)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small inconsistency between git and package install in format of reported version

2 participants