Add location info for KToken#3012
Merged
rv-jenkins merged 2 commits intodevelopfrom Oct 25, 2022
Merged
Conversation
Contributor
|
@radumereuta I tested this commit on my code and it appears to solve the issue for me! Thanks. |
sskeirik
approved these changes
Oct 24, 2022
Contributor
sskeirik
left a comment
sskeirik
left a comment
There was a problem hiding this comment.
I don't know if the code is right, but it works for my test case, so I'm approving it. You may want someone else with more familiarity with the code to chime in though.
Contributor
Author
|
Thank you @sskeirik |
ehildenb
approved these changes
Oct 24, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This occurred when trying to move a rule like this:
We didn't properly add the location information when we did the transformation from TreeNodes to KORE and it was failing with a
None.get.@sskeirik can you please confirm this solves your issue?