Automatically import BOOL when strictness is applied#3036
Automatically import BOOL when strictness is applied#3036rv-jenkins merged 6 commits intodevelopfrom
Conversation
dwightguth
left a comment
There was a problem hiding this comment.
We should generally be very careful about automatically importing things.
Before we merge this, please check whether importing BOOL into the main module fixes this issue; if it does, we should probably just fix the error message.
|
@dwightguth you can't even write a I think we should likely follow whatever we're doing elsewhere. As long as it's documented well, we should be OK with it. But I guess it should be disabled if the user wants too (eg. |
|
The 95% case is that users want to have BOOL implicitly imported, but we should have an escape hatch (credit to Bruce). I think I agree with this. |
|
Sounds like the consensus is that this should just work, so I'll rescind my review. |
|
A summary:
$ kast -e 'true andBool false'
`_andBool_`(#token("true","Bool"),#token("false","Bool"))
One thing I agree with is that documentation should be updated, so I pushed another commit. Please re-review. |
Fixes: #2564
This is done for the compiled definition so we don't taint program parsing.