Reimplement check for [anywhere] rules on the haskell backend#3051
Merged
rv-jenkins merged 6 commits intodevelopfrom Nov 18, 2022
Merged
Reimplement check for [anywhere] rules on the haskell backend#3051rv-jenkins merged 6 commits intodevelopfrom
[anywhere] rules on the haskell backend#3051rv-jenkins merged 6 commits intodevelopfrom
Conversation
Baltoli
force-pushed
the
anywhere-check
branch
2 times, most recently
from
6fc0fc5 to
a446152
Compare
Baltoli
force-pushed
the
anywhere-check
branch
from
a446152 to
c4237d5
Compare
6 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed, this PR reinstates the previous change with an additional code path that allows anywhere rules to be sent to the backend if the user explicitly guarantees they know what they're doing; a warning is flagged in this case.
The tests ensure that the LLVM backend treats rules sensibly, and that the Haskell backend doesn't crash when given one of these rules.
I have tested this on the C semantics (the original motivating case for dropping this in the first place), and the flag works as intended.
Fixes #2909