Forbid [anywhere, symbolic]#3053
Merged
rv-jenkins merged 2 commits intodevelopfrom Nov 22, 2022
Merged
Conversation
Contributor
|
Seems fine but I'd like @ana-pantilie to confirm this won't break anything. I know in the past we were using anywhere for some stuff unrelated to anywhere rules and I just want to confirm that is no longer an issue. |
dwightguth
approved these changes
Nov 21, 2022
ana-pantilie
approved these changes
Nov 22, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Haskell backend doesn't support anywhere rules, so we should forbid the attribute on
symbolicrules as we already do forsimplificationrules: #2711Doing so prevents the LLVM backend from crashing with an uninformative error message in certain contexts.
Fixes runtimeverification/llvm-backend#329